We should instead check for the corresponding agents to be enabled (network, timeline).
Created attachment 165604 [details] Patch
Comment on attachment 165604 [details] Patch Attachment 165604 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/14032091
Comment on attachment 165604 [details] Patch Attachment 165604 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14006511
Comment on attachment 165604 [details] Patch Attachment 165604 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/14035066
Comment on attachment 165604 [details] Patch Attachment 165604 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14021123
Comment on attachment 165604 [details] Patch Attachment 165604 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14006512
Comment on attachment 165604 [details] Patch Attachment 165604 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14036037
Comment on attachment 165604 [details] Patch Attachment 165604 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/14035068
Comment on attachment 165604 [details] Patch Attachment 165604 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14027115
Created attachment 165612 [details] Patch
Comment on attachment 165612 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165612&action=review > Source/WebCore/inspector/InspectorCanvasAgent.h:67 > + bool enabled() { return m_enabled; } plz remove this. CanvasAgent is enabled if it has been set in the InstrumentingAgents. e.g. the canvasAgentEnabled() check resemble to the timelineAgentEnabled(), rather than consoleAgentEnabled()
(In reply to comment #11) > (From update of attachment 165612 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=165612&action=review > > > Source/WebCore/inspector/InspectorCanvasAgent.h:67 > > + bool enabled() { return m_enabled; } > > plz remove this. CanvasAgent is enabled if it has been set in the InstrumentingAgents. e.g. the canvasAgentEnabled() check resemble to the timelineAgentEnabled(), rather than consoleAgentEnabled() *resemble -> should resemble
Created attachment 165617 [details] Patch
Comment on attachment 165617 [details] Patch Clearing flags on attachment: 165617 Committed r129751: <http://trac.webkit.org/changeset/129751>
All reviewed patches have been landed. Closing bug.
Mike, this patch might effect your eval stack collection patch.
Re-opened since this is blocked by bug 97921
This patched weas rolled out due to crashes, see http://code.google.com/p/chromium/issues/detail?id=152947 I think this might have been caused by the lack of the non-null check of instrumentingAgentsForContext(scriptExecutionContext) in return instrumentingAgentsForContext(scriptExecutionContext)->inspectorTimelineAgent(); (InspectorInstrumentation.cpp:1165)
Committed r130021: <http://trac.webkit.org/changeset/130021>