Should have a DOMCriticalSection RAII class which forbids event dispatch, etc. while on the stack 
https://bugs.webkit.org/show_bug.cgi?id=96702
Summary Should have a DOMCriticalSection RAII class which forbids event dispatch, etc...
Eric Seidel (no email)
Reported 2012-09-13 15:40:55 PDT
Should have a DOMCriticalSection RAIA which forbids event dispatch, etc. while on the stack Right now we do this manually, and rather ad-hoc. We should have some slicker tools for annotating when the DOM is in an inconsistent state and we do not expect JS to run. This came up again while reviewing bug 93639
Attachments
Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-09-13 16:13:24 PDT
forbidEventDispatch is something like that, but probably doesn't cover all the cases you'd like to cover.
Alexey Proskuryakov
Comment 2 2012-09-14 13:03:23 PDT
A good idea, although I'm not a big fan of "DOMCriticalSection" name. Besides event dispatch, what forbidden code do you have in mind for these sections?
Ryosuke Niwa
Comment 3 2012-09-14 13:48:20 PDT
(In reply to comment #2) > A good idea, although I'm not a big fan of "DOMCriticalSection" name. Besides event dispatch, what forbidden code do you have in mind for these sections? *WidgetHierarchyUpdates is a good candidate.
Note You need to log in before you can comment on or make changes to this bug.