RESOLVED FIXED 96698
Lots of repaints in the top left tile on this site
https://bugs.webkit.org/show_bug.cgi?id=96698
Summary Lots of repaints in the top left tile on this site
Simon Fraser (smfr)
Reported 2012-09-13 14:53:59 PDT
Note how, when you load http://www.telegraaf.nl/, the top left tile is continually repainting. If you scroll down you'll see a ticker on the right; deleting this ticker stops the repaints. But why is the top left tile repainting? TileCache::setNeedsDisplayInRect() calls: getTileIndexRangeForRect(intersection(enclosingIntRect(scaledRect), m_tileCoverageRect), topLeft, bottomRight); but in some cases intersection(enclosingIntRect(scaledRect), m_tileCoverageRect) returns an empty rect. However, getTileIndexRangeForRect happily returns tile 0,0 in that case, so we dirty the top left tile anyway.
Attachments
Patch (2.17 KB, patch)
2012-09-13 16:39 PDT, Simon Fraser (smfr)
andersca: review+
Simon Fraser (smfr)
Comment 1 2012-09-13 14:55:58 PDT
Oh, I think the repaint will fall outside of the tile rect so this is probably a no-op. However, with repaint counters on, we dirty the repaint counter in the tile. So some cleanup would be good.
Simon Fraser (smfr)
Comment 2 2012-09-13 16:39:16 PDT
Simon Fraser (smfr)
Comment 3 2012-09-13 17:02:41 PDT
Note You need to log in before you can comment on or make changes to this bug.