Bug 96679 - Typo in RenderStyle::isFlippedLinesWritingMode(), small refactoring possible
Summary: Typo in RenderStyle::isFlippedLinesWritingMode(), small refactoring possible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hans Muller
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-13 12:07 PDT by Hans Muller
Modified: 2012-09-13 14:20 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.62 KB, patch)
2012-09-13 12:19 PDT, Hans Muller 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Muller 2012-09-13 12:07:08 PDT 
The following comment from RenderStyle.h is wrong, "vertical-rl" should be vertical-lr:

    // Bottom of the line occurs earlier in the block; modes vertical-rl or horizontal-bt.
    bool isFlippedLinesWritingMode() const { return writingMode() == LeftToRightWritingMode || writingMode() == BottomToTopWritingMode; }

The semantics of the inline functions in WritingMode.h are a little bit difficult to divine, at least they were for me. The functions are essentially duplicated in RenderStyle.h, where they appear with comments.  The RenderStyle.h versions should be defined int terms of the inlines defined in WritingMode.h, and the handy comments could be relocated to WritingMode.h.
Comment 1 Hans Muller 2012-09-13 12:19:49 PDT 
Created attachment 163933 [details]
Patch
Comment 2 WebKit Review Bot 2012-09-13 14:20:49 PDT 
Comment on attachment 163933 [details]
Patch

Clearing flags on attachment: 163933

Committed r128508: <http://trac.webkit.org/changeset/128508>
Comment 3 WebKit Review Bot 2012-09-13 14:20:52 PDT 
All reviewed patches have been landed.  Closing bug.