Bug 96668 - [CSS Shaders] Enable anti-aliasing on the FECustomFilter
Summary: [CSS Shaders] Enable anti-aliasing on the FECustomFilter
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexandru Chiculita
Depends on:
Reported: 2012-09-13 10:40 PDT by Alexandru Chiculita
Modified: 2012-09-14 13:08 PDT (History)
2 users (show)

See Also:

Patch V1 (11.72 KB, patch)
2012-09-13 17:22 PDT, Alexandru Chiculita
dino: review+
Details | Formatted Diff | Diff
Patch for landing (11.99 KB, patch)
2012-09-14 12:51 PDT, Alexandru Chiculita
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandru Chiculita 2012-09-13 10:40:22 PDT
FECustomFilter needs anti-aliasing, otherwise the result has stair-case effect on the margins.
Comment 1 Alexandru Chiculita 2012-09-13 17:22:12 PDT
Created attachment 164007 [details]
Patch V1

This patch will fail to apply because it needs the refactor in https://bugs.webkit.org/show_bug.cgi?id=96579 .
Comment 2 Dean Jackson 2012-09-14 09:29:22 PDT
Comment on attachment 164007 [details]
Patch V1

View in context: https://bugs.webkit.org/attachment.cgi?id=164007&action=review

> Source/WebCore/platform/graphics/filters/FECustomFilter.cpp:351
> +    int sampleCount = std::min(4, maxSampleCount);

While it's only used here, I think we should define a MAX_CUSTOM_SAMPLES or something at the top of the file.

> Source/WebCore/platform/graphics/filters/FECustomFilter.cpp:362
> +    m_context->bindFramebuffer(GraphicsContext3D::FRAMEBUFFER, m_multisampleFrameBuffer);
> +
> +    m_context->bindRenderbuffer(GraphicsContext3D::RENDERBUFFER, m_multisampleRenderBuffer);

nit: remove blank line
Comment 3 Alexandru Chiculita 2012-09-14 12:51:00 PDT
Created attachment 164210 [details]
Patch for landing
Comment 4 Alexandru Chiculita 2012-09-14 12:53:36 PDT
Comment on attachment 164210 [details]
Patch for landing

The patch cannot apply because of the diff in the changelog :)
Comment 5 Alexandru Chiculita 2012-09-14 13:08:28 PDT
Landed in http://trac.webkit.org/changeset/128646 .