Bug 96666 - [chromium] alter fling animation parameters.
Summary: [chromium] alter fling animation parameters.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robert Kroeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-13 10:12 PDT by Robert Kroeger
Modified: 2012-09-13 13:26 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.40 KB, patch)
2012-09-13 10:22 PDT, Robert Kroeger 		no flags Details | Formatted Diff | Diff
Patch (1.94 KB, patch)
2012-09-13 12:33 PDT, Robert Kroeger 		no flags Details | Formatted Diff | Diff
Patch (2.22 KB, patch)
2012-09-13 12:58 PDT, Robert Kroeger 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Kroeger 2012-09-13 10:12:10 PDT 
Extend the tail of fling animations based on user feedback.
Comment 1 Robert Kroeger 2012-09-13 10:22:41 PDT 
Created attachment 163901 [details]
Patch
Comment 2 Robert Kroeger 2012-09-13 10:23:30 PDT 
enne@ Could you review please?
Comment 3 Robert Kroeger 2012-09-13 10:23:31 PDT 
enne@ Could you review please?
Comment 4 W. James MacLean 2012-09-13 10:31:56 PDT 
(In reply to comment #1)
> Created an attachment (id=163901) [details]
> Patch

lgtm !
Comment 5 Adrienne Walker 2012-09-13 10:43:04 PDT 
Comment on attachment 163901 [details]
Patch

R=me.
Comment 6 WebKit Review Bot 2012-09-13 11:16:10 PDT 
Comment on attachment 163901 [details]
Patch

Clearing flags on attachment: 163901

Committed r128483: <http://trac.webkit.org/changeset/128483>
Comment 7 WebKit Review Bot 2012-09-13 11:16:13 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 James Robinson 2012-09-13 11:51:20 PDT 
You broke PlatformGestureCurve.flingCurveTouch on all platforms.  Please fix ASAP.  Failure log:

PlatformGestureCurve.flingCurveTouch: 
../../third_party/WebKit/Source/WebKit/chromium/tests/PlatformGestureCurveTest.cpp:110: Failure
Value of: animation->animate(1.5)
  Actual: true
Expected: false
../../third_party/WebKit/Source/WebKit/chromium/tests/PlatformGestureCurveTest.cpp:111: Failure
The difference between target.cumulativeDelta().x() and 1193 is 1569, which exceeds 1, where
target.cumulativeDelta().x() evaluates to 2762,
1193 evaluates to 1193, and
1 evaluates to 1.
Comment 9 Robert Kroeger 2012-09-13 12:33:07 PDT 
Created attachment 163936 [details]
Patch
Comment 10 Adrienne Walker 2012-09-13 12:36:52 PDT 
Comment on attachment 163936 [details]
Patch

R=me.  In the future, please do not upload multiple patches to the same bug in WebKit.  Create a new bug instead.
Comment 11 Robert Kroeger 2012-09-13 12:58:07 PDT 
Created attachment 163943 [details]
Patch
Comment 12 WebKit Review Bot 2012-09-13 13:26:02 PDT 
Comment on attachment 163943 [details]
Patch

Clearing flags on attachment: 163943

Committed r128501: <http://trac.webkit.org/changeset/128501>
Comment 13 WebKit Review Bot 2012-09-13 13:26:06 PDT 
All reviewed patches have been landed.  Closing bug.