RESOLVED FIXED Bug 96662
Web Inspector: [Tests] Extract a common method for sending xhrs from tests. 
https://bugs.webkit.org/show_bug.cgi?id=96662
Summary Web Inspector: [Tests] Extract a common method for sending xhrs from tests.
Vsevolod Vlasov
Reported 2012-09-13 09:41:54 PDT
Patch to follow
Attachments
Patch (44.12 KB, patch)
2012-09-13 09:43 PDT, Vsevolod Vlasov 		apavlov: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2012-09-13 09:43:53 PDT
Created attachment 163891 [details] Patch
Alexander Pavlov (apavlov)
Comment 2 2012-09-14 01:16:35 PDT
Comment on attachment 163891 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163891&action=review > LayoutTests/ChangeLog:3 > + Web Inspector: [Tests] Extract a common method for sending xhrs from tests. WebKit convention is to capitalize full acronyms, even in identifiers (like "runXHRTest") > LayoutTests/http/tests/inspector/network-test.js:98 > +function makeXHR(jsonArgs) Please come up with a consistent naming convention for these methods (doXHR vs. makeXHR vs. InspectorTest.makeXHR*)
Vsevolod Vlasov
Comment 3 2012-09-14 01:35:56 PDT
Committed r128569: <http://trac.webkit.org/changeset/128569>
Note You need to log in before you can comment on or make changes to this bug.