Bug 96661 - [BlackBerry] ResourceRequest string optimizations
Summary: [BlackBerry] ResourceRequest string optimizations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yong Li
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-13 09:35 PDT by George Staikos
Modified: 2012-09-13 13:04 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.20 KB, patch)
2012-09-13 09:37 PDT, George Staikos 		no flags Details | Formatted Diff | Diff
the patch (1.63 KB, patch)
2012-09-13 12:07 PDT, Yong Li 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description George Staikos 2012-09-13 09:35:26 PDT 
Reduce string ops in ResourceRequest
Comment 1 George Staikos 2012-09-13 09:37:02 PDT 
Created attachment 163890 [details]
Patch
Comment 2 Yong Li 2012-09-13 12:07:06 PDT 
Created attachment 163929 [details]
the patch
Comment 3 Yong Li 2012-09-13 12:21:50 PDT 
forgot to put the PR in changelog.

it is PR 207965.
Comment 4 Rob Buis 2012-09-13 12:45:40 PDT 
Comment on attachment 163929 [details]
the patch

Looks good, more concise :)
Comment 5 WebKit Review Bot 2012-09-13 12:55:20 PDT 
Comment on attachment 163929 [details]
the patch

Rejecting attachment 163929 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ueue/Source/WebKit/chromium/third_party/leveldatabase/src --revision 67 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
37>At revision 67.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/13855116
Comment 6 Yong Li 2012-09-13 13:04:23 PDT 
manually landed @r128497
Comment 7 Yong Li 2012-09-13 13:04:37 PDT 
Comment on attachment 163929 [details]
the patch

clear flags