Bug 96656 - check-webkit-style should not warn in case of NONCOPYABLE and FAST_ALLOCATED macros
Summary: check-webkit-style should not warn in case of NONCOPYABLE and FAST_ALLOCATED ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zoltan Horvath
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-13 08:35 PDT by Zoltan Horvath
Modified: 2012-09-14 10:05 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.83 KB, patch)
2012-09-14 03:16 PDT, Zoltan Horvath 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2012-09-13 08:35:09 PDT 
Stylebot sends (More than one command on the same line  [whitespace/newline] [4]) warning 
if WTF_MAKE_NONCOPYABLE(ClassName); and WTF_MAKE_FAST_ALLOCATED; macros are used in the same line.

Since it is the preferred style, the script should not warn about it. (e.g. https://bugs.webkit.org/show_bug.cgi?id=96512#c2)
Comment 1 Zoltan Horvath 2012-09-14 03:16:42 PDT 
Created attachment 164085 [details]
Patch
Comment 2 Adam Barth 2012-09-14 09:58:34 PDT 
Comment on attachment 164085 [details]
Patch

ok
Comment 3 WebKit Review Bot 2012-09-14 10:05:10 PDT 
Comment on attachment 164085 [details]
Patch

Clearing flags on attachment: 164085

Committed r128624: <http://trac.webkit.org/changeset/128624>
Comment 4 WebKit Review Bot 2012-09-14 10:05:14 PDT 
All reviewed patches have been landed.  Closing bug.