WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 96656
check-webkit-style should not warn in case of NONCOPYABLE and FAST_ALLOCATED macros
https://bugs.webkit.org/show_bug.cgi?id=96656
Summary
check-webkit-style should not warn in case of NONCOPYABLE and FAST_ALLOCATED ...
Zoltan Horvath
Reported
2012-09-13 08:35:09 PDT
Stylebot sends (More than one command on the same line [whitespace/newline] [4]) warning if WTF_MAKE_NONCOPYABLE(ClassName); and WTF_MAKE_FAST_ALLOCATED; macros are used in the same line. Since it is the preferred style, the script should not warn about it. (e.g.
https://bugs.webkit.org/show_bug.cgi?id=96512#c2
)
Attachments
Patch
(2.83 KB, patch)
2012-09-14 03:16 PDT
,
Zoltan Horvath
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Zoltan Horvath
Comment 1
2012-09-14 03:16:42 PDT
Created
attachment 164085
[details]
Patch
Adam Barth
Comment 2
2012-09-14 09:58:34 PDT
Comment on
attachment 164085
[details]
Patch ok
WebKit Review Bot
Comment 3
2012-09-14 10:05:10 PDT
Comment on
attachment 164085
[details]
Patch Clearing flags on attachment: 164085 Committed
r128624
: <
http://trac.webkit.org/changeset/128624
>
WebKit Review Bot
Comment 4
2012-09-14 10:05:14 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug