Bug 96651 - [BlackBerry] Page Popup for Month is non-functional.
Summary: [BlackBerry] Page Popup for Month is non-functional.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: WebExposed
Depends on:
Blocks:
 
Reported: 2012-09-13 07:38 PDT by jecao
Modified: 2012-09-13 16:38 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.51 KB, patch)
2012-09-13 07:54 PDT, jecao 		no flags Details | Formatted Diff | Diff
Patch (2.51 KB, patch)
2012-09-13 08:13 PDT, jecao 		no flags Details | Formatted Diff | Diff
Patch (2.50 KB, patch)
2012-09-13 08:22 PDT, jecao 		no flags Details | Formatted Diff | Diff
Patch (2.49 KB, patch)
2012-09-13 08:26 PDT, jecao 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jecao 2012-09-13 07:38:18 PDT 
<input type=month> is completely non-functional.  It behaves like it is requesting a dialog, but no dialog appears.  Likely this is missing an implementation for the type and the fail over isn't handled well.
Comment 1 jecao 2012-09-13 07:54:36 PDT 
Created attachment 163876 [details]
Patch
Comment 2 Mike Fenton 2012-09-13 08:10:42 PDT 
Comment on attachment 163876 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163876&action=review

> Source/WebKit/blackberry/WebCoreSupport/DatePickerClient.cpp:77
> +        source.append("window.popupcontrol.show(\"Month\", ");

This should be appendLiteral.
Comment 3 jecao 2012-09-13 08:13:49 PDT 
Created attachment 163878 [details]
Patch
Comment 4 Rob Buis 2012-09-13 08:15:10 PDT 
Comment on attachment 163878 [details]
Patch

LGTM.
Comment 5 WebKit Review Bot 2012-09-13 08:17:45 PDT 
Comment on attachment 163878 [details]
Patch

Rejecting attachment 163878 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Chris Hutten-Czapski found in /mnt/git/webkit-commit-queue/Source/WebKit/blackberry/ChangeLog does not appear to be a valid reviewer according to committers.py.
ERROR: /mnt/git/webkit-commit-queue/Source/WebKit/blackberry/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/13852049
Comment 6 jecao 2012-09-13 08:22:12 PDT 
Created attachment 163881 [details]
Patch
Comment 7 jecao 2012-09-13 08:26:16 PDT 
Created attachment 163882 [details]
Patch
Comment 8 Rob Buis 2012-09-13 08:27:20 PDT 
Comment on attachment 163882 [details]
Patch

LGTM.
Comment 9 WebKit Review Bot 2012-09-13 09:01:23 PDT 
Comment on attachment 163882 [details]
Patch

Clearing flags on attachment: 163882

Committed r128471: <http://trac.webkit.org/changeset/128471>
Comment 10 WebKit Review Bot 2012-09-13 09:01:27 PDT 
All reviewed patches have been landed.  Closing bug.