Bug 96648 – Replace qInstallMsgHandler() with qInstallMessageHandler()

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Kai Koehne]

In qt5 / qtbase, qInstallMsgHandler() got deprecated, and replaced by qInstallMessageHandler. QtWebkit should use the new API.

[Kai Koehne]

Created attachment 163869 [details]
patch using the new API

[Peter Gal]

(In reply to comment #1)
> Created an attachment (id=163869) [details]
> patch using the new API

Just a sidenote, I've found this about qPrintable:
http://lists.trolltech.com/qt-interest/2007-12/thread00508-0.html

Is this still valid? if so we could use .constData() as in:
http://qt-project.org/doc/qt-5.0/qtglobal.html#qInstallMessageHandler

[Kai Koehne]

qPrintable(string) 

is actually just a macro that expands to

QString(string).toLocal8Bit().constData() 

The e-mail of qt-interest was about whether the temporary QByteArray created by toLocal8Bit() is guaranteed to be still valid by the time printf(...) is executed, and the answer (at the bottom of the thread) is that it is: It can only be destroyed after the whole statement has executed. So

printf("%s", qPrintable(x));

is okay while

const char * str = qPrintable(x);
printf("%s", str);

isn't.

[Jocelyn Turcotte]

Comment on attachment 163869 [details]
patch using the new API

View in context: https://bugs.webkit.org/attachment.cgi?id=163869&action=review

> Source/WebKit2/ChangeLog:4
> +	https://bugs.webkit.org/show_bug.cgi?id=96648

Spaces instead of tabs please.

[Kai Koehne]

Created attachment 165577 [details]
patch using the new API

fixed tab usage.

[Andras Becsi]

Comment on attachment 165577 [details]
patch using the new API

As the purple bubbles indicate your patch does not apply. Could you update it to WebKit trunk so that the early warning system and the commit queue can process it.

[Kai Koehne]

Created attachment 166179 [details]
patch using the new API

Updated to apply to webkit / master.

[Andras Becsi]

Comment on attachment 166179 [details]
patch using the new API

This patch does not have a changelog.

[Kai Koehne]

Created attachment 166184 [details]
patch using the new API

Duh, I'm sorry. I hope I got it this time right...

[Andras Becsi]

Comment on attachment 166184 [details]
patch using the new API

LGTM. Simon or Jocelyn can toggle the review flag for you :)

[Jocelyn Turcotte]

Comment on attachment 166184 [details]
patch using the new API

Thanks a lot :)

[WebKit Review Bot]

Comment on attachment 166184 [details]
patch using the new API

Clearing flags on attachment: 166184

Committed r129870: <http://trac.webkit.org/changeset/129870>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.