Issue with convolver node usage in webkit2:webAudio API

[kdj]

Hi,

I was trying to run few WebAudio API applications from chrome site; especially for convolverNode.

App name: Digital DJ 
Link: http://chromium.googlecode.com/svn/trunk/samples/audio/dj.html
This application did not work properly, for small fraction the audio came and further the silence played out.

After removing the convolverNode; referring the lines in application.
...
line no.: 386: //convolver.connect(preCompressorGain);
...
line no.: 397: //setReverbImpulseResponse('impulse-responses/filter-rhythm2.wav');
...

The application worked perfectly :-) 

To investigate further, with enabled convolverNode and I added data dump logs in following places at same time:
1. ConvolverNode::process() for input(0)->bus(), to check input to convolverNode.
2. webKitWebAudioSrcLoop(), for (const_cast<float*>(priv->bus->channel(index)->data())).

The data for 1. is complete silence whereas for 2. it is proper convoluted stream.

Here it seems that the WebAudio API convolverNode has issue before connecting to other node. 
I tried to other application which are using ConvolverNode; result is same "for small fraction the audio came and further the silence played out".

Please share your views.

Thanks and regards,
kaustubh

[Philippe Normand]

That demo works fine here with your patch from bug 95833. Without that patch I can hear the pop noise glitches of bug 82347 (so I'll close the last as dupe of the first btw).

Tested with a 64-bit release build of webkitgtk.

Should we close this one?

[kdj]

Good it is working on 64-bit !

I have tested with 32-bit machine.

Could you please share your 64-bit release details on which it is working. So that I can try for the same one at my end.

Is it OK to take tar ball "WebKit r128500" ?

Thanks,
kdj

[Philippe Normand]

What kind of details about my setup do you need?

[kdj]

I am getting this error with WebKit r128500:

  CXX    Source/JavaScriptCore/Programs_jsc_3-jsc.o
  CXX    Source/WebKit2/gtk/Programs_WebKitWebProcess-MainGtk.o
  CXXLD  Programs/WebKitPluginProcess
libtool: link: cannot find the library `libjavascriptcoregtk-3.0.la' or unhandled argument `libjavascriptcoregtk-3.0.la'
make[1]: *** [Programs/WebKitPluginProcess] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory `/home/newgen/webkit-org/WebKit-r128500/WebKitBuild/Release'
make: *** [all] Error 2

I tried with this path:  http://savannah.gnu.org/bugs/?30653

Could you please tell/guide the exact patch for the same ?

[Philippe Normand]

If you do build-webkit --gtk --update-gtk it should work. Please join #webkitgtk+ if you have build issues, bugzilla is not the best place to discuss about that.

[kdj]

Ok, I registered to #webkitgtk+ and able to build on 64bit webkitGtk with webaudio.
I tried to run the same app link. But not able to hear the audio. 

Please tell me anything more you are doing at your end.

[Philippe Normand]

Have you set the AUDIO_RESOURCES_PATH env variable to point to .../Source/WebCore/platform/audio/resources ?

[kdj]

yes, after setting same Env var, Convolver node is working; thanks philippe.