Bug 96625 - Refactor paint overflow clipping
Summary: Refactor paint overflow clipping
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sami Kyöstilä
URL:
Keywords:
Depends on:
Blocks: 96087
  Show dependency treegraph
 
Reported: 2012-09-13 02:59 PDT by Sami Kyöstilä
Modified: 2012-09-13 10:22 PDT (History)
5 users (show)

See Also:


Attachments
Patch (7.77 KB, patch)
2012-09-13 03:06 PDT, Sami Kyöstilä
no flags Details | Formatted Diff | Diff
Patch (7.77 KB, patch)
2012-09-13 03:15 PDT, Sami Kyöstilä
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sami Kyöstilä 2012-09-13 02:59:20 PDT
Refactor paint overflow clipping
Comment 1 Sami Kyöstilä 2012-09-13 03:06:06 PDT
Created attachment 163827 [details]
Patch
Comment 2 Sami Kyöstilä 2012-09-13 03:15:36 PDT
Created attachment 163828 [details]
Patch
Comment 3 Antonio Gomes 2012-09-13 06:41:21 PDT
Comment on attachment 163828 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163828&action=review

> Source/WebCore/rendering/RenderBox.cpp:1588
> +    rect.setLocation(topLeft);

is it ok to change the rect.location here unconditionally now? (previously it was within the else).
Comment 4 Sami Kyöstilä 2012-09-13 07:08:32 PDT
Comment on attachment 163828 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163828&action=review

>> Source/WebCore/rendering/RenderBox.cpp:1588
>> +    rect.setLocation(topLeft);
> 
> is it ok to change the rect.location here unconditionally now? (previously it was within the else).

Both versions of the code should be equivalent. The old code constructs a temporary rectangle at (topLeft - scrollOffset, rect.size()) and assigns its intersection with the clip rect to rect. The new code does the same without the intermediate rectangle.
Comment 5 WebKit Review Bot 2012-09-13 10:21:59 PDT
Comment on attachment 163828 [details]
Patch

Clearing flags on attachment: 163828

Committed r128478: <http://trac.webkit.org/changeset/128478>
Comment 6 WebKit Review Bot 2012-09-13 10:22:02 PDT
All reviewed patches have been landed.  Closing bug.