Bug 96624 - Web Inspector: NMI: instrument KURL directly.
Summary: Web Inspector: NMI: instrument KURL directly.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
Depends on:
Reported: 2012-09-13 02:31 PDT by Ilya Tikhonovsky
Modified: 2012-09-13 05:12 PDT (History)
17 users (show)

See Also:

patch for trybots (14.41 KB, patch)
2012-09-13 02:35 PDT, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff
Patch (18.51 KB, patch)
2012-09-13 04:22 PDT, Ilya Tikhonovsky
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2012-09-13 02:31:02 PDT
I replaced traits based instrumentation of KURL with reportMemoryUsage functions.
CString* were also instrumented.
Comment 1 Ilya Tikhonovsky 2012-09-13 02:35:38 PDT
Created attachment 163822 [details]
patch for trybots
Comment 2 Yury Semikhatsky 2012-09-13 03:56:08 PDT
Comment on attachment 163822 [details]
patch for trybots

Please add a test for this change.
Comment 3 Ilya Tikhonovsky 2012-09-13 04:22:13 PDT
Created attachment 163836 [details]
Comment 4 Ilya Tikhonovsky 2012-09-13 04:47:32 PDT
(In reply to comment #3)
> Created an attachment (id=163836) [details]
> Patch

Done: visitString test was extended.
Comment 5 Ilya Tikhonovsky 2012-09-13 05:12:05 PDT
Committed r128448: <http://trac.webkit.org/changeset/128448>