Bug 96611 - Testing whether indexing type is ArrayWithArrayStorage should not compare against ArrayWithArrayStorage
Summary: Testing whether indexing type is ArrayWithArrayStorage should not compare aga...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 96596
  Show dependency tree / graph
 
Reported: 2012-09-13 00:25 PDT by Filip Pizlo
Modified: 2012-09-13 01:40 PDT (History)
0 users

See Also:

Attachments
the patch (8.88 KB, patch)
2012-09-13 00:28 PDT, Filip Pizlo 		barraclough: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-09-13 00:25:00 PDT 
We want to use m_indexingType's high bits for some additional state. That means that comparing directly against ArrayWithArrayStorage may lead to spurious failures when those high bits do get set.
Comment 1 Filip Pizlo 2012-09-13 00:28:15 PDT 
Created attachment 163801 [details]
the patch
Comment 2 Filip Pizlo 2012-09-13 01:40:14 PDT 
Landed in http://trac.webkit.org/changeset/128425