Bug 96604 - [EFL][WK2] Make _ref() functions return the object
Summary: [EFL][WK2] Make _ref() functions return the object
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-12 23:10 PDT by Chris Dumez
Modified: 2012-09-13 00:35 PDT (History)
5 users (show)

See Also:

Attachments
Patch (19.83 KB, patch)
2012-09-12 23:22 PDT, Chris Dumez 		gyuyoung.kim: review+
Details | Formatted Diff | Diff
Patch for landing (19.84 KB, patch)
2012-09-13 00:15 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-09-12 23:10:35 PDT 
We should make the *_ref() functions return the object in Ewk APIs to make it more convenient to use:

e.g. the following:
  ewk_download_job_ref(ewkDownload);
  ewkContext->downloadJobs.add(downloadId, ewkDownload);

is replaced by:
  ewkContext->downloadJobs.add(downloadId, ewk_download_job_ref(ewkDownload));

This is consistent with eina_stringshare_ref() API in EFL and g_object_ref() in glib.
Comment 1 Chris Dumez 2012-09-12 23:22:39 PDT 
Created attachment 163787 [details]
Patch
Comment 2 Chris Dumez 2012-09-12 23:24:23 PDT 
Of course, I'll update the EFL coding guidelines when this lands.
Comment 3 Gyuyoung Kim 2012-09-12 23:37:54 PDT 
Comment on attachment 163787 [details]
Patch

Looks good refactoring.
Comment 4 Gyuyoung Kim 2012-09-12 23:55:33 PDT 
Comment on attachment 163787 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163787&action=review

> Source/WebKit2/ChangeLog:3
> +        [EFL] Make _ref() functions return the object

Nit: missing [WK2] prefix.
Comment 5 Chris Dumez 2012-09-13 00:15:08 PDT 
Created attachment 163797 [details]
Patch for landing

Could someone please cq+?
Comment 6 WebKit Review Bot 2012-09-13 00:35:36 PDT 
Comment on attachment 163797 [details]
Patch for landing

Clearing flags on attachment: 163797

Committed r128413: <http://trac.webkit.org/changeset/128413>
Comment 7 WebKit Review Bot 2012-09-13 00:35:40 PDT 
All reviewed patches have been landed.  Closing bug.