Bug 96602 – -ldl should not be hardcoded into OPENGL_LIBS

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Alexandre Rostovtsev]

(As reported downstream at https://bugs.gentoo.org/show_bug.cgi?id=417523)

Some non-linux systems, for example freebsd, have dlopen()/dlclose()/dlsym() etc. in their core libc, and do not install a separate libdl. On such systems, "-ldl" in OPENGL_LIBS leads to linking failure.

webkit's configure should check whether libc provides dlopen, and add -ldl to OPENGL_LIBS only if it's needed.

[Alexandre Rostovtsev]

Created attachment 163774 [details]
proposed patch for current svn trunk

[Patrick Nicolas]

The patch adds twice the dash: OPENGL_LIBS="-lGL --libdl" and build fails

(In reply to comment #1)
> Created an attachment (id=163774) [details]
> proposed patch for current svn trunk

[Alexandre Rostovtsev]

Created attachment 164670 [details]
proposed patch, v2

(In reply to comment #2)
> The patch adds twice the dash: OPENGL_LIBS="-lGL --libdl" and build fails

You are right, thanks for noticing. Fixed in this revision.

[Alexandre Rostovtsev]

Created attachment 170343 [details]
proposed patch, v3

Updated for current svn trunk

[Xan Lopez]

Comment on attachment 170343 [details]
proposed patch, v3

View in context: https://bugs.webkit.org/attachment.cgi?id=170343&action=review

> configure.ac:282
> +AC_SUBST([DLOPEN_LIBS])

This makes sense, but would you mind adding a small comment saying what it does? Mostly because it's checking for the uncommon case (BSD-ish systems), so it's possible that a maintainer will be confused in the future. Something like:

"We check whether dlopen is in the core libraries; if it's not we pull in libdl if it has dlopen and is available, as it's needed in GNU/Linux."

Thanks!

[Alexandre Rostovtsev]

Created attachment 170351 [details]
proposed patch, v4

(In reply to comment #5)

OK, comment added.

[WebKit Review Bot]

Comment on attachment 170351 [details]
proposed patch, v4

Clearing flags on attachment: 170351

Committed r139643: <http://trac.webkit.org/changeset/139643>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.