Bug 96598 - [EFL] Improve string manipulation in EflKeyboardUtilities.cpp
Summary: [EFL] Improve string manipulation in EflKeyboardUtilities.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-12 21:19 PDT by Ryuan Choi
Modified: 2012-09-13 15:58 PDT (History)
5 users (show)

See Also:

Attachments
Patch (14.30 KB, patch)
2012-09-12 21:44 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2012-09-12 21:19:33 PDT 
I think that we should remove String::format and use ASCIILiteral.
Patch will be added.
Comment 1 Ryuan Choi 2012-09-12 21:44:57 PDT 
Created attachment 163770 [details]
Patch
Comment 2 Benjamin Poulain 2012-09-13 13:43:14 PDT 
Comment on attachment 163770 [details]
Patch

Looks good to me.
Comment 3 WebKit Review Bot 2012-09-13 15:58:23 PDT 
Comment on attachment 163770 [details]
Patch

Clearing flags on attachment: 163770

Committed r128519: <http://trac.webkit.org/changeset/128519>
Comment 4 WebKit Review Bot 2012-09-13 15:58:27 PDT 
All reviewed patches have been landed.  Closing bug.