Bug 96595 - [Tests] We should have tests for preserving/resetting values of input type "time" after browser navigation
Summary: [Tests] We should have tests for preserving/resetting values of input type "t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: yosin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-12 20:42 PDT by yosin
Modified: 2012-09-13 02:37 PDT (History)
1 user (show)

See Also:

Attachments
Patch 1 (7.74 KB, patch)
2012-09-12 20:49 PDT, yosin 		no flags Details | Formatted Diff | Diff
Patch 2 (7.93 KB, patch)
2012-09-12 23:03 PDT, yosin 		no flags Details | Formatted Diff | Diff
Patch 3 (8.13 KB, patch)
2012-09-12 23:17 PDT, yosin 		no flags Details | Formatted Diff | Diff
Patch 4 (8.95 KB, patch)
2012-09-13 02:07 PDT, yosin 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description yosin 2012-09-12 20:42:39 PDT 
Browser navigation, e.g. reload, history.back, and history.forward, should preserve values of input type "time".
Comment 1 yosin 2012-09-12 20:49:05 PDT 
Created attachment 163766 [details]
Patch 1
Comment 2 yosin 2012-09-12 21:26:38 PDT 
Comment on attachment 163766 [details]
Patch 1

Could you review this patch?
Thanks in advance.
Comment 3 yosin 2012-09-12 23:03:08 PDT 
Created attachment 163783 [details]
Patch 2
Comment 4 yosin 2012-09-12 23:05:13 PDT 
Comment on attachment 163783 [details]
Patch 2

Could you review this patch?
Thanks in advance.

= Changes since the last review =
* Rename test file time-multiple-fields-preserve-value-after-reload.* to time-multiple-fields-not-preserve-value-after-reload.*
* Change reload test does right thing. Previous version checked value before reloaded.
Comment 5 yosin 2012-09-12 23:17:24 PDT 
Created attachment 163786 [details]
Patch 3
Comment 6 yosin 2012-09-12 23:18:17 PDT 
Comment on attachment 163786 [details]
Patch 3

Could you review this patch?
Thanks in advance.

= Changes since the last review =
* Rename test file time-multiple-fields-preserve-value-after-reload.* to time-multiple-fields-reset-value-after-reload.*
* Change reload test does right thing. Previous version checked value before reloaded.
Comment 7 Kent Tamura 2012-09-12 23:40:57 PDT 
Comment on attachment 163786 [details]
Patch 3

View in context: https://bugs.webkit.org/attachment.cgi?id=163786&action=review

> LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back-expected.txt:9
> +PASS "backward full";"01:01" is "01:01"
> +PASS "backward partial";"" is ""
> +PASS "forward full";"02:02" is "02:02"
> +PASS "forward partial";"" is ""

"backward/forward full/partial" is hard to understand unless reading the test code carefully.  Please show more descriptive strings.
e.g.

Went back to a page. Checking a field which had a full value:
PASS "01:01" is "01:01"
Went back to a page. Checking a field which had a partial value:
..
Comment 8 yosin 2012-09-13 02:07:18 PDT 
Created attachment 163818 [details]
Patch 4
Comment 9 yosin 2012-09-13 02:08:59 PDT 
Comment on attachment 163818 [details]
Patch 4

Could you review this patch?
Thank in advance.

= Changes since the last review =
* Change test output descriptive in time-multiple-fields-preserve-value-after-history-back.html
Comment 10 Kent Tamura 2012-09-13 02:30:25 PDT 
Comment on attachment 163818 [details]
Patch 4

ok
Comment 11 yosin 2012-09-13 02:37:13 PDT 
Comment on attachment 163818 [details]
Patch 4

Clearing flags on attachment: 163818

Committed r128434: <http://trac.webkit.org/changeset/128434>
Comment 12 yosin 2012-09-13 02:37:17 PDT 
All reviewed patches have been landed.  Closing bug.