Bug 96582 - new test fast/canvas/canvas-css-crazy.html fails on Mac
Summary: new test fast/canvas/canvas-css-crazy.html fails on Mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords: InRadar, MakingBotsRed
: 96606 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-09-12 17:33 PDT by Stephanie Lewis
Modified: 2012-09-13 00:15 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.43 KB, patch)
2012-09-12 22:36 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephanie Lewis 2012-09-12 17:33:26 PDT 
http://trac.webkit.org/changeset/128374 introduced fast/canvas/canvas-css-crazy.html which fails on the Mac. 

http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r128381%20(3497)/results.html

--- /Volumes/Data/slave/lion-release-tests-wk1/build/layout-test-results/fast/canvas/canvas-css-crazy-expected.txt
+++ /Volumes/Data/slave/lion-release-tests-wk1/build/layout-test-results/fast/canvas/canvas-css-crazy-actual.txt
@@ -1,2 +1,3 @@
+ALERT: FAIL! ctx wasn't null: undefined
 ALERT: PASS
Comment 1 Radar WebKit Bug Importer 2012-09-12 17:33:43 PDT 
<rdar://problem/12289384>
Comment 2 Adam Barth 2012-09-12 18:30:50 PDT 
This is just a minor (long-standing) bug in the custom JSC bindings.  /me will fix shortly.
Comment 3 Stephanie Lewis 2012-09-12 18:32:22 PDT 
Thanks.  Is there a bug on JSC bindings issue?
Comment 4 Adam Barth 2012-09-12 18:35:17 PDT 
> Thanks.  Is there a bug on JSC bindings issue?

Nope!  This is it now.  (I didn't know it existed until you told me that this test fails.)
Comment 5 Adam Barth 2012-09-12 22:36:46 PDT 
Created attachment 163778 [details]
Patch
Comment 6 Adam Barth 2012-09-12 23:38:08 PDT 
*** Bug 96606 has been marked as a duplicate of this bug. ***
Comment 7 Csaba Osztrogonác 2012-09-12 23:55:03 PDT 
Comment on attachment 163778 [details]
Patch

rs=me
Comment 8 WebKit Review Bot 2012-09-13 00:15:45 PDT 
Comment on attachment 163778 [details]
Patch

Clearing flags on attachment: 163778

Committed r128411: <http://trac.webkit.org/changeset/128411>
Comment 9 WebKit Review Bot 2012-09-13 00:15:48 PDT 
All reviewed patches have been landed.  Closing bug.