Bug 96577 – Remove webkitPostMessage

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore JavaScript

[Adam Barth]

Remove webkitPostMessage

[Adam Barth]

Created attachment 163739 [details]
patch for discussion

[Eric Seidel (no email)]

Comment on attachment 163739 [details]
patch for discussion

OK.  Do we have any concept of how much content on teh web depends on this?

[Maciej Stachowiak]

This probably shouldn't be r+'d or committed until the webkit-dev discussion has settled. See thread starting here: http://lists.webkit.org/pipermail/webkit-dev/2012-September/022189.html

[Adam Barth]

> Do we have any concept of how much content on teh web depends on this?

We don't have any hard numbers.  I wasn't able to find any uses when I looked with various code search tools.  As far as I can tell, its existence was only mentioned in one tutorial.

> This probably shouldn't be r+'d or committed until the webkit-dev discussion has settled.

Yes, I didn't actually mean to set the r? flag.  I just wanted to post a patch so that we had something concrete to discuss.

[Adam Barth]

Created attachment 163989 [details]
Patch

[Adam Barth]

This updated patch reflects the further discussion on webkit-dev. Let's see if the EWS thinks it builds on all the various ports.

[Ojan Vafai]

Comment on attachment 163989 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163989&action=review

> Source/WebCore/GNUmakefile.am:470
> +endif  # END ENABLE_LEGACY_WEBKIT_BLOB_BUILDER

copy-paste lol

> Source/WebCore/workers/Worker.idl:1
> +e/*

Not likely to build. :)

[Adam Barth]

Created attachment 163991 [details]
Patch

[Adam Barth]

Created attachment 163992 [details]
Patch

[Adam Barth]

Created attachment 163995 [details]
Patch

[kov's GTK+ EWS bot]

Comment on attachment 163995 [details]
Patch

Attachment 163995 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/13855191

[Gyuyoung Kim]

Comment on attachment 163995 [details]
Patch

Attachment 163995 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13851300

[Build Bot]

Comment on attachment 163995 [details]
Patch

Attachment 163995 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13855194

[Early Warning System Bot]

Comment on attachment 163995 [details]
Patch

Attachment 163995 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13855196

[Adam Barth]

Created attachment 164006 [details]
Patch

[Adam Barth]

The bots are green now.  Anyone care to review?

[Ojan Vafai]

Comment on attachment 164006 [details]
Patch

Would be nice to include a brief description in the ChangeLog about why a generic legacy flag makes sense instead of one specific to postmessage (e.g. that once we've confirmed getting rid of it is OK we can just delete this code and avoid the overhead of constantly adding/removing flags per prefix).

[Adam Barth]

Will do.  I'm going to wait until Wed to land this patch so that it will have a full Dev cycle to bake.

[Adam Barth]

Actually, I'm going to land this with ENABLE_LEGACY_VENDOR_PREFIXES turned on everywhere and then flip the flag for Chromium on Wed so that this patch doesn't bit rot.

[Adam Barth]

Created attachment 164221 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 164221 [details]
Patch for landing

Clearing flags on attachment: 164221

Committed r128658: <http://trac.webkit.org/changeset/128658>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Adam Barth]

Not actually removed quite yet!  We still need to flip the enable bit.

[Adam Barth]

Created attachment 164812 [details]
Patch

[WebKit Review Bot]

Comment on attachment 164812 [details]
Patch

Clearing flags on attachment: 164812

Committed r129085: <http://trac.webkit.org/changeset/129085>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.