Bug 96556 - [V8] V8DOMWrapper::constructorForType is unnecessary now that we can get V8PerContextData from the v8::Context
Summary: [V8] V8DOMWrapper::constructorForType is unnecessary now that we can get V8Pe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-12 14:00 PDT by Adam Barth
Modified: 2012-09-12 14:36 PDT (History)
4 users (show)

See Also:

Attachments
Patch (8.01 KB, patch)
2012-09-12 14:01 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch for landing (9.03 KB, patch)
2012-09-12 14:12 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch for landing (9.03 KB, patch)
2012-09-12 14:12 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-09-12 14:00:19 PDT 
[V8] V8DOMWrapper::constructorForType is unnecessary now that we can get V8PerContextData from the v8::Context
Comment 1 Adam Barth 2012-09-12 14:01:59 PDT 
Created attachment 163689 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-09-12 14:09:52 PDT 
Comment on attachment 163689 [details]
Patch

So much red...
Comment 3 Adam Barth 2012-09-12 14:12:08 PDT 
Created attachment 163691 [details]
Patch for landing
Comment 4 Adam Barth 2012-09-12 14:12:47 PDT 
Created attachment 163692 [details]
Patch for landing
Comment 5 Adam Barth 2012-09-12 14:13:01 PDT 
Now with run-bindings-tests results.
Comment 6 WebKit Review Bot 2012-09-12 14:36:27 PDT 
Comment on attachment 163692 [details]
Patch for landing

Clearing flags on attachment: 163692

Committed r128361: <http://trac.webkit.org/changeset/128361>
Comment 7 WebKit Review Bot 2012-09-12 14:36:31 PDT 
All reviewed patches have been landed.  Closing bug.