Bug 96551 - IndexedDB: The |source| property of IDBFactory.open() request should be null
Summary: IndexedDB: The |source| property of IDBFactory.open() request should be null
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joshua Bell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-12 13:32 PDT by Joshua Bell
Modified: 2012-09-12 19:06 PDT (History)
5 users (show)

See Also:

Attachments
Patch (8.33 KB, patch)
2012-09-12 13:35 PDT, Joshua Bell 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Bell 2012-09-12 13:32:07 PDT 
IndexedDB: The |source| property of IDBFactory.open() request should be null
Comment 1 Joshua Bell 2012-09-12 13:35:10 PDT 
Created attachment 163680 [details]
Patch
Comment 2 Joshua Bell 2012-09-12 13:36:11 PDT 
Identified via W3C test submission:

http://w3c-test.org/webapps/IndexedDB/tests/submissions/Microsoft/idbfactory_open.htm

dgrogan@ - can you take a look?
Comment 3 David Grogan 2012-09-12 13:41:42 PDT 
LGTM
Comment 4 Joshua Bell 2012-09-12 13:42:16 PDT 
Another easy one - tony@ - r? cq?
Comment 5 WebKit Review Bot 2012-09-12 15:21:44 PDT 
Comment on attachment 163680 [details]
Patch

Clearing flags on attachment: 163680

Committed r128370: <http://trac.webkit.org/changeset/128370>
Comment 6 WebKit Review Bot 2012-09-12 15:21:47 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Kent Tamura 2012-09-12 18:57:14 PDT 
It seems this broke IndexedDBLayoutTest.BasicTests in Chromium content_browsertests.  I'll roll r128370 out.
Comment 9 David Grogan 2012-09-12 19:00:25 PDT 
Doh, we forgot about basics-shared-workers-expected.txt
Comment 10 Kent Tamura 2012-09-12 19:03:21 PDT 
(In reply to comment #9)
> Doh, we forgot about basics-shared-workers-expected.txt

The failure isn't a regression, is it?   So, I won't roll it out.
Comment 11 David Grogan 2012-09-12 19:06:12 PDT 
(In reply to comment #10)
> (In reply to comment #9)
> > Doh, we forgot about basics-shared-workers-expected.txt
> 
> The failure isn't a regression, is it?   So, I won't roll it out.

Right, we just need to update the expected file. I'll do that now.

Thanks!