NEW 9655
obj-c test scripts need access to WebView in DumpRenderTree 
https://bugs.webkit.org/show_bug.cgi?id=9655
Summary obj-c test scripts need access to WebView in DumpRenderTree
James G. Speth
Reported 2006-06-29 12:36:41 PDT
To facilitate more complex test scripts for the objective-c API, DumpRenderTree should expose the current WebView to the script environment. This should be done only when [ObjCPlugin removeBridgeRestrictions:] is called.
Attachments
patch for review (2.74 KB, patch)
2006-07-04 18:01 PDT, James G. Speth 		mjs: review-
DetailsFormatted DiffDiff
patch without leaks (7.61 KB, patch)
2006-07-05 03:51 PDT, James G. Speth 		darin: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
James G. Speth
Comment 1 2006-07-04 18:01:43 PDT
Created attachment 9199 [details] patch for review One thing to note is that when using this, tests will leak an additional frame (since the WebView itself is stored into the script environment). This leak can be avoided if the WebView reference is disposed of and garbage collection is forced.
Maciej Stachowiak
Comment 2 2006-07-04 18:49:51 PDT
Looks good but we really don't want the layout tests to leak. We have a buildbot to track leaks and are trying to fix the existing ones. Please post a version that doesn't leak.
James G. Speth
Comment 3 2006-07-05 03:51:13 PDT
Created attachment 9205 [details] patch without leaks i changed the way scripts access the WebView and window to prevent leaking. this includes a test for the plugin method that exposes this access to the script.
Darin Adler
Comment 4 2006-07-08 09:07:27 PDT
Comment on attachment 9205 [details] patch without leaks The call to removeBridgeRestrictions: here has the same leak I've fixed in my recent patch -- the JSObjC object is allocated but not released. Otherwise looks fine.
Eric Seidel (no email)
Comment 5 2007-09-30 12:16:37 PDT
This is a nice, but sadly forgotten, patch. Perhaps mr. speth will return from the woodwork.
Note You need to log in before you can comment on or make changes to this bug.