Bug 96528 - Respect WEBKITOUTPUTDIR when running EFL tests
Summary: Respect WEBKITOUTPUTDIR when running EFL tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kenneth Rohde Christiansen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-12 08:39 PDT by Kenneth Rohde Christiansen
Modified: 2012-09-12 14:48 PDT (History)
9 users (show)

See Also:

Attachments
Patch (1.83 KB, patch)
2012-09-12 08:41 PDT, Kenneth Rohde Christiansen 		no flags Details | Formatted Diff | Diff
Patch (1.88 KB, patch)
2012-09-12 13:56 PDT, Kenneth Rohde Christiansen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Rohde Christiansen 2012-09-12 08:39:56 PDT 
SSIA
Comment 1 Kenneth Rohde Christiansen 2012-09-12 08:41:21 PDT 
Created attachment 163641 [details]
Patch
Comment 2 Dirk Pranke 2012-09-12 09:24:57 PDT 
Comment on attachment 163641 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163641&action=review

> Tools/Scripts/webkitpy/layout_tests/port/driver.py:280
> +        environment['WEBKITOUTPUTDIR'] = os.environ['WEBKITOUTPUTDIR']

I think this probably needs to be guarded by if 'WEBKITOUTPUTDIR' in os.environ since this may not always be set ...
Comment 3 Kenneth Rohde Christiansen 2012-09-12 13:55:26 PDT 
(In reply to comment #2)
> I think this probably needs to be guarded by if 'WEBKITOUTPUTDIR' in os.environ since this may not always be set ...

You are right, python loves throwing exceptions instead of returning None :-)
Comment 4 Kenneth Rohde Christiansen 2012-09-12 13:56:05 PDT 
Created attachment 163686 [details]
Patch
Comment 5 WebKit Review Bot 2012-09-12 14:48:46 PDT 
Comment on attachment 163686 [details]
Patch

Clearing flags on attachment: 163686

Committed r128364: <http://trac.webkit.org/changeset/128364>
Comment 6 WebKit Review Bot 2012-09-12 14:48:50 PDT 
All reviewed patches have been landed.  Closing bug.