WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
96484
Remove last call to numberToString() from WebCore code
https://bugs.webkit.org/show_bug.cgi?id=96484
Summary
Remove last call to numberToString() from WebCore code
Patrick R. Gansterer
Reported
2012-09-12 02:28:00 PDT
Remove last call to numberToString() from WebCore code
Attachments
Patch
(5.61 KB, patch)
2012-09-12 02:36 PDT
,
Patrick R. Gansterer
no flags
Details
Formatted Diff
Diff
Patch
(4.82 KB, patch)
2012-09-12 02:37 PDT
,
Patrick R. Gansterer
haraken
: review+
haraken
: commit-queue-
Details
Formatted Diff
Diff
Patch
(4.82 KB, patch)
2012-09-12 02:56 PDT
,
Patrick R. Gansterer
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1
2012-09-12 02:36:30 PDT
Created
attachment 163560
[details]
Patch
Patrick R. Gansterer
Comment 2
2012-09-12 02:37:44 PDT
Created
attachment 163561
[details]
Patch
Kentaro Hara
Comment 3
2012-09-12 02:44:47 PDT
Comment on
attachment 163561
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=163561&action=review
Looks OK.
> Source/WebCore/ChangeLog:8 > + Repace WTF::numberToString() with String::numberToStringECMAScript() to remove duplicated
Typo: Replace. Sorry for a nit-picking, but let's just fix it before landing.
Patrick R. Gansterer
Comment 4
2012-09-12 02:56:24 PDT
Created
attachment 163567
[details]
Patch
WebKit Review Bot
Comment 5
2012-09-12 06:50:40 PDT
Comment on
attachment 163567
[details]
Patch Clearing flags on attachment: 163567 Committed
r128303
: <
http://trac.webkit.org/changeset/128303
>
WebKit Review Bot
Comment 6
2012-09-12 06:50:44 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug