Bug 96484 - Remove last call to numberToString() from WebCore code
Summary: Remove last call to numberToString() from WebCore code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-12 02:28 PDT by Patrick R. Gansterer
Modified: 2012-09-12 06:50 PDT (History)
4 users (show)

See Also:

Attachments
Patch (5.61 KB, patch)
2012-09-12 02:36 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
Patch (4.82 KB, patch)
2012-09-12 02:37 PDT, Patrick R. Gansterer 		haraken: review+
haraken: commit-queue-
Details | Formatted Diff | Diff
Patch (4.82 KB, patch)
2012-09-12 02:56 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2012-09-12 02:28:00 PDT 
Remove last call to numberToString() from WebCore code
Comment 1 Patrick R. Gansterer 2012-09-12 02:36:30 PDT 
Created attachment 163560 [details]
Patch
Comment 2 Patrick R. Gansterer 2012-09-12 02:37:44 PDT 
Created attachment 163561 [details]
Patch
Comment 3 Kentaro Hara 2012-09-12 02:44:47 PDT 
Comment on attachment 163561 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163561&action=review

Looks OK.

> Source/WebCore/ChangeLog:8
> +        Repace WTF::numberToString() with String::numberToStringECMAScript() to remove duplicated

Typo: Replace. Sorry for a nit-picking, but let's just fix it before landing.
Comment 4 Patrick R. Gansterer 2012-09-12 02:56:24 PDT 
Created attachment 163567 [details]
Patch
Comment 5 WebKit Review Bot 2012-09-12 06:50:40 PDT 
Comment on attachment 163567 [details]
Patch

Clearing flags on attachment: 163567

Committed r128303: <http://trac.webkit.org/changeset/128303>
Comment 6 WebKit Review Bot 2012-09-12 06:50:44 PDT 
All reviewed patches have been landed.  Closing bug.