Bug 96483 – Web Inspector: Persistent handle referenced from ScriptWrappable is double counted

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Yury Semikhatsky]

ScriptWrappable::m_wrapper is a pointer to an entry in the array where all such handles are stored. Since the handle is a part of a bigger object we should not count it second time when visiting the pointer in ScriptWrappable.

[Yury Semikhatsky]

Created attachment 163558 [details]
Patch

[Alexander Pavlov (apavlov)]

Comment on attachment 163558 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163558&action=review

> Source/WTF/ChangeLog:10
> +        used on fields that are pointers to objects which a parts of bigger memory

"a parts" -> "are parts"?

> Source/WTF/ChangeLog:11
> +        blocks(field of another object, element in an array, object allocated in a

Missing whitespace between 's' and '('

> Source/WTF/ChangeLog:12
> +        memory arena etc.). We don't want to count such objects memory separately

objects'

> Source/WebCore/ChangeLog:11
> +        second time. In order to make the clang plugin that validate memory instrumentation

validate -> validates

> Source/WebCore/ChangeLog:12
> +        happy we report it here as weak pointer(no-op).

missing whitespace

[Yury Semikhatsky]

(In reply to comment #2)
> (From update of attachment 163558 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=163558&action=review
> 
> > Source/WTF/ChangeLog:10
> > +        used on fields that are pointers to objects which a parts of bigger memory
> 
> "a parts" -> "are parts"?
> 
Done.

> > Source/WTF/ChangeLog:11
> > +        blocks(field of another object, element in an array, object allocated in a
> 
> Missing whitespace between 's' and '('
> 
Done.

> > Source/WTF/ChangeLog:12
> > +        memory arena etc.). We don't want to count such objects memory separately
> 
> objects'
> 
Done.

> > Source/WebCore/ChangeLog:11
> > +        second time. In order to make the clang plugin that validate memory instrumentation
> 
> validate -> validates
> 
Done.

> > Source/WebCore/ChangeLog:12
> > +        happy we report it here as weak pointer(no-op).
> 
> missing whitespace
Done.

[Yury Semikhatsky]

Committed r128283: <http://trac.webkit.org/changeset/128283>