Bug 96464 - IncrementalSweeper should not sweep/free Zapped blocks
Summary: IncrementalSweeper should not sweep/free Zapped blocks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
: 95516 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-09-11 20:10 PDT by Mark Hahnenberg
Modified: 2012-09-12 13:56 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.69 KB, patch)
2012-09-11 20:16 PDT, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2012-09-11 20:10:47 PDT 
This is not beneficial in terms of performance, and since don't take zapped-ness into account when determining whether or not a block is empty to free it, it unintentionally causes pre-mature freeing of blocks.
Comment 1 Mark Hahnenberg 2012-09-11 20:12:56 PDT 
This was a regression introduced in http://trac.webkit.org/changeset/121316.
Comment 2 Mark Hahnenberg 2012-09-11 20:16:31 PDT 
Created attachment 163505 [details]
Patch
Comment 3 WebKit Review Bot 2012-09-11 21:25:54 PDT 
Comment on attachment 163505 [details]
Patch

Clearing flags on attachment: 163505

Committed r128262: <http://trac.webkit.org/changeset/128262>
Comment 4 WebKit Review Bot 2012-09-11 21:25:57 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Alexey Proskuryakov 2012-09-12 13:56:33 PDT 
*** Bug 95516 has been marked as a duplicate of this bug. ***