WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
96461
Fix build break with LLINT on 32bit machine after
r128219
https://bugs.webkit.org/show_bug.cgi?id=96461
Summary
Fix build break with LLINT on 32bit machine after r128219
Ryuan Choi
Reported
2012-09-11 19:51:12 PDT
I am not sure because I don't know javascript world. But I think that .opGetArrayLengthSlot looks typo.
Attachments
Patch
(1.38 KB, patch)
2012-09-11 19:54 PDT
,
Ryuan Choi
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ryuan Choi
Comment 1
2012-09-11 19:54:01 PDT
Created
attachment 163502
[details]
Patch
Ryuan Choi
Comment 2
2012-09-11 20:04:59 PDT
This it to fix build break on 32bit EFL built bot. Below is error message in
http://build.webkit.org/builders/EFL%20Linux%2032-bit%20Release%20%28Build%29/builds/6487/steps/compile-webkit/logs/stdio
offlineasm: Nothing changed. [ 4%] Generating ../../DerivedSources/JavaScriptCore/LLIntAssembly.h offlineasm: Parsing /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter.asm and /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/WebKitBuild/Release/bin/LLIntOffsetsExtractor and creating assembly file /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/WebKitBuild/Release/DerivedSources/JavaScriptCore/LLIntAssembly.h. offlineasm: Nothing changed. [ 10%] Built target javascriptcore_efl Linking CXX executable ../../../bin/jsc ../../../lib/libjavascriptcore_efl.so.0.1.0: undefined reference to `.L_offlineasm_opGetArrayLengthSlot' collect2: ld returned 1 exit status make[2]: *** [bin/jsc] Error 1 make[1]: *** [Source/JavaScriptCore/shell/CMakeFiles/jsc.dir/all] Error 2 make[1]: *** Waiting for unfinished jobs.... [ 84%] Built target webcore_efl make: *** [all] Error 2 program finished with exit code 2 elapsedTime=53.367220
Hojong Han
Comment 3
2012-09-11 20:21:51 PDT
I think so. It should be corrected to opGetArrayLengthSlow
WebKit Review Bot
Comment 4
2012-09-11 20:36:27 PDT
Comment on
attachment 163502
[details]
Patch Clearing flags on attachment: 163502 Committed
r128259
: <
http://trac.webkit.org/changeset/128259
>
WebKit Review Bot
Comment 5
2012-09-11 20:36:31 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug