Bug 96458 – [chromium] Flip Y and swizzle inside compositeAndReadback implementation

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alexandre Elias]

[chromium] Flip Y and swizzle inside compositeAndReadback implementation

[Alexandre Elias]

Created attachment 163497 [details]
Patch

[Dana Jansens]

How come this doesn't require changing DumpRenderTree (since it does flipping too?)

[Alexandre Elias]

DumpRenderTree uses the WebViewImpl call; I have been testing this change by running DumpRenderTree.

[James Robinson]

Comment on attachment 163497 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163497&action=review

DumpRenderTree uses WebViewImpl, so the total # of flips  / swizzles should be the same for the GL path in DRT.

> Source/WebCore/platform/graphics/chromium/cc/CCRendererGL.cpp:1177
> +    int rowBytes = rect.width() * 4;

size_t would be marginally more consistent with other code that does byte addressing (overflow isn't a realistic concern here, but consistency is still nice)

[Dana Jansens]

(In reply to comment #3)
> DumpRenderTree uses the WebViewImpl call; I have been testing this change by running DumpRenderTree.

Ah I see, I thought it had some other flip in TestShell somewheres.. guess not! Thanks :)

[Alexandre Elias]

Created attachment 163525 [details]
Patch

Switched types to size_t

[WebKit Review Bot]

Comment on attachment 163525 [details]
Patch

Rejecting attachment 163525 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/13822632

[WebKit Review Bot]

Comment on attachment 163525 [details]
Patch

Clearing flags on attachment: 163525

Committed r128269: <http://trac.webkit.org/changeset/128269>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.