Bug 96458 - [chromium] Flip Y and swizzle inside compositeAndReadback implementation
Summary: [chromium] Flip Y and swizzle inside compositeAndReadback implementation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexandre Elias
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-11 19:16 PDT by Alexandre Elias
Modified: 2012-09-12 00:01 PDT (History)
7 users (show)

See Also:


Attachments
Patch (7.08 KB, patch)
2012-09-11 19:23 PDT, Alexandre Elias
no flags Details | Formatted Diff | Diff
Patch (7.10 KB, patch)
2012-09-11 23:37 PDT, Alexandre Elias
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandre Elias 2012-09-11 19:16:12 PDT
[chromium] Flip Y and swizzle inside compositeAndReadback implementation
Comment 1 Alexandre Elias 2012-09-11 19:23:44 PDT
Created attachment 163497 [details]
Patch
Comment 2 Dana Jansens 2012-09-11 23:21:26 PDT
How come this doesn't require changing DumpRenderTree (since it does flipping too?)
Comment 3 Alexandre Elias 2012-09-11 23:28:05 PDT
DumpRenderTree uses the WebViewImpl call; I have been testing this change by running DumpRenderTree.
Comment 4 James Robinson 2012-09-11 23:29:28 PDT
Comment on attachment 163497 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163497&action=review

DumpRenderTree uses WebViewImpl, so the total # of flips  / swizzles should be the same for the GL path in DRT.

> Source/WebCore/platform/graphics/chromium/cc/CCRendererGL.cpp:1177
> +    int rowBytes = rect.width() * 4;

size_t would be marginally more consistent with other code that does byte addressing (overflow isn't a realistic concern here, but consistency is still nice)
Comment 5 Dana Jansens 2012-09-11 23:31:25 PDT
(In reply to comment #3)
> DumpRenderTree uses the WebViewImpl call; I have been testing this change by running DumpRenderTree.

Ah I see, I thought it had some other flip in TestShell somewheres.. guess not! Thanks :)
Comment 6 Alexandre Elias 2012-09-11 23:37:29 PDT
Created attachment 163525 [details]
Patch

Switched types to size_t
Comment 7 WebKit Review Bot 2012-09-11 23:40:04 PDT
Comment on attachment 163525 [details]
Patch

Rejecting attachment 163525 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/13822632
Comment 8 WebKit Review Bot 2012-09-12 00:01:39 PDT
Comment on attachment 163525 [details]
Patch

Clearing flags on attachment: 163525

Committed r128269: <http://trac.webkit.org/changeset/128269>
Comment 9 WebKit Review Bot 2012-09-12 00:01:43 PDT
All reviewed patches have been landed.  Closing bug.