Bug 96450 - [Scoped Style] NodeRareData::m_numberOfScopedHTMLStyleChildren could be replaced with a node flag.
Summary: [Scoped Style] NodeRareData::m_numberOfScopedHTMLStyleChildren could be repla...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hajime Morrita
URL:
Keywords:
Depends on:
Blocks: 72352 59827
  Show dependency tree / graph
 
Reported: 2012-09-11 16:55 PDT by Hajime Morrita
Modified: 2012-09-12 09:54 PDT (History)
2 users (show)

See Also:

Attachments
Patch (8.69 KB, patch)
2012-09-11 18:41 PDT, Hajime Morrita 		no flags Details | Formatted Diff | Diff
Patch for landing (9.04 KB, patch)
2012-09-12 09:21 PDT, Hajime Morrita 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2012-09-11 16:55:10 PDT 
Since this member is hit frequently in StyleResolver, this looks worth killed by a bit flag,
which is much efficient.
Comment 1 Hajime Morrita 2012-09-11 18:41:50 PDT 
Created attachment 163493 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2012-09-11 20:38:30 PDT 
Comment on attachment 163493 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163493&action=review

> Source/WebCore/ChangeLog:10
> +        Instead of tracking the number of certain node, this chagne compute the number

chagne->change

> Source/WebCore/html/HTMLStyleElement.cpp:128
> +    // Note: We cannot rely on the 'scoped' element still being present when this method is invoked.

I think he meant 'scoped' _attribute_?
Comment 3 Build Bot 2012-09-11 20:42:23 PDT 
Comment on attachment 163493 [details]
Patch

Attachment 163493 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13832193
Comment 4 Build Bot 2012-09-11 21:17:15 PDT 
Comment on attachment 163493 [details]
Patch

Attachment 163493 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13827484
Comment 5 Hajime Morrita 2012-09-12 09:11:14 PDT 
Dimitri, thank for taking a look at such a late at night!
I'll address the points and land the change.

(In reply to comment #2)
> (From update of attachment 163493 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=163493&action=review
> 
> > Source/WebCore/ChangeLog:10
> > +        Instead of tracking the number of certain node, this chagne compute the number
> 
> chagne->change
Will fix. hmm.

> 
> > Source/WebCore/html/HTMLStyleElement.cpp:128
> > +    // Note: We cannot rely on the 'scoped' element still being present when this method is invoked.
> 
> I think he meant 'scoped' _attribute_?
Well, I just moved this around. But yes, it looks. Will fix.
Comment 6 Hajime Morrita 2012-09-12 09:21:06 PDT 
Created attachment 163646 [details]
Patch for landing
Comment 7 WebKit Review Bot 2012-09-12 09:54:32 PDT 
Comment on attachment 163646 [details]
Patch for landing

Clearing flags on attachment: 163646

Committed r128331: <http://trac.webkit.org/changeset/128331>
Comment 8 WebKit Review Bot 2012-09-12 09:54:35 PDT 
All reviewed patches have been landed.  Closing bug.