Bug 96439 - jsStringWithCache shouldn't call StringImpl::characters() for single character strings
Summary: jsStringWithCache shouldn't call StringImpl::characters() for single characte...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-11 15:53 PDT by Michael Saboff
Modified: 2012-09-11 17:26 PDT (History)
1 user (show)

See Also:


Attachments
Patch (2.02 KB, patch)
2012-09-11 15:58 PDT, Michael Saboff
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2012-09-11 15:53:45 PDT
This is to fix two FIXME's in jsStringWithCache.
    // FIXME: we shouldn't invoke StringImpl::characters().
    // FIXME: why not just return a SmallStrings when possible?
Comment 1 Michael Saboff 2012-09-11 15:58:56 PDT
Created attachment 163464 [details]
Patch
Comment 2 Geoffrey Garen 2012-09-11 16:07:53 PDT
Comment on attachment 163464 [details]
Patch

r=me
Comment 3 WebKit Review Bot 2012-09-11 16:53:24 PDT
Comment on attachment 163464 [details]
Patch

Clearing flags on attachment: 163464

Committed r128244: <http://trac.webkit.org/changeset/128244>
Comment 4 WebKit Review Bot 2012-09-11 16:53:27 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Michael Saboff 2012-09-11 17:26:07 PDT
Additional commit of r128247: <http://trac.webkit.org/changeset/128247>