Bug 96429 – Add 'any' type to V8 bindings as a synonym for DOMObject

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alec Flett]

Add 'any' type to V8 bindings as a synonym for DOMObject

[Alec Flett]

Created attachment 163453 [details]
Patch

[Alec Flett]

I have no idea what I'm doing.

Ok, I have some idea.

But I don't know how much of JSC I should worry about. 

haraken@ or abarth@ - can you offer any guidance?

[Adam Barth]

Comment on attachment 163453 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163453&action=review

> Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:1369
> +    impl->setAnyAttribute(SerializedScriptValue::create(exec, value, 0, 0));

This seems to imply that "any" maps to SerializedScriptValue is JSC.  Is that what you intend?

[Alec Flett]

Created attachment 163479 [details]
Patch

[Kentaro Hara]

Comment on attachment 163479 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163479&action=review

OK

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:251
> +        or $type eq "DOMString" or $type eq "DOMObject" or $type eq "any" or$type eq "Array" or $type eq "DOMTimeStamp") {

Nit: One space please after 'or'.

[Alec Flett]

Created attachment 163483 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 163483 [details]
Patch for landing

Clearing flags on attachment: 163483

Committed r128248: <http://trac.webkit.org/changeset/128248>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.