Bug 96422 - Update ICU header files to more recent version
Summary: Update ICU header files to more recent version
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-11 14:05 PDT by Michael Saboff
Modified: 2012-09-11 18:58 PDT (History)
1 user (show)

See Also:

Attachments
Patch as zip file (391.72 KB, application/zip)
2012-09-11 14:43 PDT, Michael Saboff 		ggaren: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2012-09-11 14:05:56 PDT 
The current version of the ICU include files is 3.2 from 2006.  Since this files are used to access the API in the system provided libraries, we should update include files to more recent version.  THis would also allow the use of newer APIs.
Comment 1 Michael Saboff 2012-09-11 14:43:02 PDT 
Created attachment 163446 [details]
Patch as zip file

Source of files is ICU release 4.6.1 with some modifications.

From the ChangeLogs:
        Updated ICU header files to 4.6.1.  Modifications made as part of the merge are:
        platform.h - Changed ifndef / define / endif for U_HAVE_UINT8_T, U_HAVE_UINT16_T, U_HAVE_UINT32_T,
            U_HAVE_UINT64_T, U_IS_BIG_ENDIAN and U_ENABLE_TRACING to match the existing platform.h
        putil.h (line 132) - Changes defined(U_WINDOWS) to defined(WIN32) || defined(OS2) to match existing putil.h
        ustring.h (line 945) - Wrapped macro argument cs with { (const UChar *)cs } to match existing ustring.h
        utypes.h (line 545) - Changed defined(U_WINDOWS) to defined(WIN32) to match existing utypes.h

Added localpointer.h and uvernum.h to JavaScriptCore/icu/unicode WTF/icu/unicode WebCore/icu/unicode WebKit/mac/icu/unicode.
Added utext.h to Source/WebCore/icu/unicode.
Comment 2 WebKit Review Bot 2012-09-11 14:49:02 PDT 
Attachment 163446 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files']" exit_code: 1
Total errors found: 0 in 0 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Geoffrey Garen 2012-09-11 15:58:34 PDT 
Comment on attachment 163446 [details]
Patch as zip file

r=me
Comment 4 Michael Saboff 2012-09-11 16:50:32 PDT 
Committed r128243: <http://trac.webkit.org/changeset/128243>
Comment 5 Michael Saboff 2012-09-11 17:09:54 PDT 
Additional commit of r128246: <http://trac.webkit.org/changeset/128246>
Comment 6 Michael Saboff 2012-09-11 17:53:38 PDT 
Additional commit of r128250: <http://trac.webkit.org/changeset/128250>
Comment 7 Michael Saboff 2012-09-11 18:27:29 PDT 
Additional commit of r128252: <http://trac.webkit.org/changeset/128252>
Comment 8 Michael Saboff 2012-09-11 18:58:16 PDT 
Additional commits of r128255: <http://trac.webkit.org/changeset/128255> and r128256: <http://trac.webkit.org/changeset/128256>