WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 9642
GMail Editor: Operations that use drop down menus blow away the selection
https://bugs.webkit.org/show_bug.cgi?id=9642
Summary
GMail Editor: Operations that use drop down menus blow away the selection
Justin Garcia
Reported
2006-06-28 15:24:32 PDT
Font Style, Size, Color and Background Color all use execCommands we support, but when they are performed, there's no selection, because its blown away when the user mouse downs inside the drop down menu.
Attachments
Patch applied as r15358
(10.38 KB, patch)
2006-07-11 15:57 PDT
,
David Kilzer (:ddkilzer)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Justin Garcia
Comment 1
2006-06-29 12:10:21 PDT
When a WebHTMLView resigns as firstResponder, we clear its selection if it doesn't maintainInactiveSelection. There's a problem with that method, it will return no unless the WebView is editable. Also, when a WebHTMLView resigns as firstResponder, we clear selections in all frames unconditionally, even if they are editable.
Justin Garcia
Comment 2
2006-07-11 15:29:37 PDT
r15358
David Kilzer (:ddkilzer)
Comment 3
2006-07-11 15:57:47 PDT
Created
attachment 9380
[details]
Patch applied as
r15358
Timothy Hatcher
Comment 4
2006-07-14 19:21:07 PDT
Reopened, Dave Harrison says this isn't fixed. Talk to him.
Timothy Hatcher
Comment 5
2006-07-14 19:21:48 PDT
Patch rolled out in
r15441
.
Justin Garcia
Comment 6
2006-07-17 12:35:09 PDT
Rolled the changes back in and removed the call to _clearSelectionInOtherFrames to -[WebHTMLView becomeFirstResponder] to fix this.
Justin Garcia
Comment 7
2006-07-17 12:35:19 PDT
r15487
.
David Kilzer (:ddkilzer)
Comment 8
2006-07-17 21:41:01 PDT
***
Bug 8497
has been marked as a duplicate of this bug. ***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug