RESOLVED FIXED 96411
Garden-o-matic should ignore a wider variety of warnings in buildbot json 
https://bugs.webkit.org/show_bug.cgi?id=96411
Summary Garden-o-matic should ignore a wider variety of warnings in buildbot json
Adam Klein
Reported 2012-09-11 11:20:37 PDT
Garden-o-matic should ignore a wider variety of warnings in buildbot json
Attachments
Patch (2.79 KB, patch)
2012-09-11 11:22 PDT, Adam Klein 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Klein
Comment 1 2012-09-11 11:22:23 PDT
Created attachment 163409 [details] Patch
Adam Barth
Comment 2 2012-09-11 11:26:43 PDT
Comment on attachment 163409 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163409&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:60 > + function isWarning(text) { return text.indexOf('warning') != -1; } > + return step.results[0] > 0 && !step.text.some(isWarning); I would have just used an anonymous function, but this is fine too.
Adam Klein
Comment 3 2012-09-11 11:29:48 PDT
Comment on attachment 163409 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163409&action=review >> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:60 >> + return step.results[0] > 0 && !step.text.some(isWarning); > > I would have just used an anonymous function, but this is fine too. I found the anonymous function version hard to reason about; adding the name made this more readable to me.
WebKit Review Bot
Comment 4 2012-09-11 11:49:50 PDT
Comment on attachment 163409 [details] Patch Clearing flags on attachment: 163409 Committed r128213: <http://trac.webkit.org/changeset/128213>
WebKit Review Bot
Comment 5 2012-09-11 11:49:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.