Bug 96411 - Garden-o-matic should ignore a wider variety of warnings in buildbot json
Summary: Garden-o-matic should ignore a wider variety of warnings in buildbot json
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Klein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-11 11:20 PDT by Adam Klein
Modified: 2012-09-11 11:49 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.79 KB, patch)
2012-09-11 11:22 PDT, Adam Klein
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Klein 2012-09-11 11:20:37 PDT
Garden-o-matic should ignore a wider variety of warnings in buildbot json
Comment 1 Adam Klein 2012-09-11 11:22:23 PDT
Created attachment 163409 [details]
Patch
Comment 2 Adam Barth 2012-09-11 11:26:43 PDT
Comment on attachment 163409 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163409&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:60
> +    function isWarning(text) { return text.indexOf('warning') != -1; }
> +    return step.results[0] > 0 && !step.text.some(isWarning);

I would have just used an anonymous function, but this is fine too.
Comment 3 Adam Klein 2012-09-11 11:29:48 PDT
Comment on attachment 163409 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163409&action=review

>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:60
>> +    return step.results[0] > 0 && !step.text.some(isWarning);
> 
> I would have just used an anonymous function, but this is fine too.

I found the anonymous function version hard to reason about; adding the name made this more readable to me.
Comment 4 WebKit Review Bot 2012-09-11 11:49:50 PDT
Comment on attachment 163409 [details]
Patch

Clearing flags on attachment: 163409

Committed r128213: <http://trac.webkit.org/changeset/128213>
Comment 5 WebKit Review Bot 2012-09-11 11:49:53 PDT
All reviewed patches have been landed.  Closing bug.