Bug 96401 – IndexedDB: Properties of IDBKeyRange should default to undefined

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Joshua Bell]

From the spec: http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#idl-def-IDBKeyRange

lowerBound(): Creates and returns a new key range with lower set to lower, lowerOpen set to open, upper set to undefined and and upperOpen set to true.
upperBound(): Creates and returns a new key range with lower set to undefined, lowerOpen set to true, upper set to upper and and upperOpen set to open.

WebKit (via Source/WebCore/binding/v8/custom/V8IDBKey.cpp) currently returns null for these, which fails a W3C test submitted by Microsoft:

http://w3c-test.org/webapps/IndexedDB/tests/submissions/Microsoft/idbkeyrange.htm

[Joshua Bell]

Created attachment 163415 [details]
Patch

[Joshua Bell]

alecflett@ - can you take a look?

[Alec Flett]

lgtm

[Joshua Bell]

Since you're already cc'd - abarth@ - r? cq?

[Adam Barth]

Comment on attachment 163415 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163415&action=review

Ok.  That's kind of strange, but if that's what we're supposed to do.

> Source/WebCore/bindings/v8/custom/V8IDBKeyCustom.cpp:44
> -        return v8NullWithCheck(isolate);
> +        return v8::Undefined();

Please call v8Undefined().  It's faster.

[Joshua Bell]

Created attachment 163903 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 163903 [details]
Patch for landing

Clearing flags on attachment: 163903

Committed r128482: <http://trac.webkit.org/changeset/128482>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.