WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
96391
[BlackBerry] Switching from Slogger to Slogger2 requires changes in CMakeList of webkit in order to include libraries of slog2
https://bugs.webkit.org/show_bug.cgi?id=96391
Summary
[BlackBerry] Switching from Slogger to Slogger2 requires changes in CMakeList...
Parth Patel
Reported
2012-09-11 08:12:56 PDT
Modification in CMakelist in JavaScriptCore of webkit to include libraries of Slog2 in build files of webkit.
Attachments
Patch
(1.54 KB, patch)
2012-09-11 08:47 PDT
,
Parth Patel
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Parth Patel
Comment 1
2012-09-11 08:47:28 PDT
Created
attachment 163376
[details]
Patch
Yong Li
Comment 2
2012-09-11 08:50:26 PDT
Comment on
attachment 163376
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=163376&action=review
LGTM
> Source/JavaScriptCore/ChangeLog:9 > + Changes in Cmake files of JavaScriptCore of webkit to include slog2 libs in build
Cmake => CMake?
Parth Patel
Comment 3
2012-09-11 08:51:18 PDT
Comment on
attachment 163376
[details]
Patch request for commit-queue? after r+
WebKit Review Bot
Comment 4
2012-09-14 06:08:12 PDT
Comment on
attachment 163376
[details]
Patch Clearing flags on attachment: 163376 Committed
r128599
: <
http://trac.webkit.org/changeset/128599
>
WebKit Review Bot
Comment 5
2012-09-14 06:08:15 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug