Bug 96388 - [WK2] [WTR] WebKitTestRunner needs TestRunner.workerThreadCount
Summary: [WK2] [WTR] WebKitTestRunner needs TestRunner.workerThreadCount
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mikhail Pozdnyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-11 07:34 PDT by Mikhail Pozdnyakov
Modified: 2012-09-12 02:09 PDT (History)
3 users (show)

See Also:


Attachments
patch (8.19 KB, patch)
2012-09-11 08:26 PDT, Mikhail Pozdnyakov
kenneth: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
to be landed (8.07 KB, patch)
2012-09-12 00:26 PDT, Mikhail Pozdnyakov
no flags Details | Formatted Diff | Diff
renamed (8.08 KB, patch)
2012-09-12 01:48 PDT, Mikhail Pozdnyakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Pozdnyakov 2012-09-11 07:34:26 PDT
WebKitTestRunner needs TestRunner.workerThreadCount in order to unskip
fast/workers/dedicated-worker-lifecycle.html
fast/workers/shared-worker-frame-lifecycle.html
fast/workers/shared-worker-lifecycle.html
fast/workers/worker-lifecycle.html
fast/workers/worker-close-more.html
Comment 1 Mikhail Pozdnyakov 2012-09-11 08:26:28 PDT
Created attachment 163371 [details]
patch
Comment 2 WebKit Review Bot 2012-09-11 08:30:21 PDT
Comment on attachment 163371 [details]
patch

Rejecting attachment 163371 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
atching file Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl
Hunk #1 succeeded at 80 (offset 1 line).
patching file Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp
Hunk #1 succeeded at 567 (offset 11 lines).
patching file Tools/WebKitTestRunner/InjectedBundle/TestRunner.h
Hunk #1 succeeded at 203 (offset 3 lines).

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Kenneth Ro..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/13828118
Comment 3 Kenneth Rohde Christiansen 2012-09-11 08:31:39 PDT
Comment on attachment 163371 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163371&action=review

> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp:274
> +size_t WKBundleWorkerThreadCount(WKBundleRef)

I think the API guidelines says to add Get in the name.
Comment 4 Mikhail Pozdnyakov 2012-09-12 00:24:44 PDT
(In reply to comment #3)
> (From update of attachment 163371 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=163371&action=review
> 
> > Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp:274
> > +size_t WKBundleWorkerThreadCount(WKBundleRef)
> 
> I think the API guidelines says to add Get in the name.

Seems not in this file:
WKBundleNumberOfPages(), WKBundlePageNumberForElementById(), WKBundlePageSizeAndMarginsInPixels() and so on..
Comment 5 Mikhail Pozdnyakov 2012-09-12 00:26:22 PDT
Created attachment 163534 [details]
to be landed
Comment 6 Kenneth Rohde Christiansen 2012-09-12 00:39:37 PDT
Comment on attachment 163534 [details]
to be landed

View in context: https://bugs.webkit.org/attachment.cgi?id=163534&action=review

> Source/WebKit2/ChangeLog:8
> +        Added WKBundleWorkerThreadCount() function to Injected Bundle private API.

Didnt we agree to rename it WKBundleGetWorkerThreadCount?
Comment 7 Mikhail Pozdnyakov 2012-09-12 01:48:56 PDT
Created attachment 163547 [details]
renamed
Comment 8 WebKit Review Bot 2012-09-12 02:09:44 PDT
Comment on attachment 163547 [details]
renamed 

Clearing flags on attachment: 163547

Committed r128278: <http://trac.webkit.org/changeset/128278>
Comment 9 WebKit Review Bot 2012-09-12 02:09:48 PDT
All reviewed patches have been landed.  Closing bug.