Bug 96387 – Crash in build script when compiling on a recent cygwin version

• Status: RESOLVED
• Resolution: WONTFIX
• Component: WebCore Misc.

[Vincent R.]

Hi,

These last days I am building lots of nightly build and I am a bit tired to apply my small patch to allow
to compile on my system(Windows XP, VS2008) so I think it would be better if I could share my patches.
THe first problem with your build system is inside webkitdirs.pm :

sub setupAppleWinEnv()
{
    return unless isAppleWinWebKit();

    if (isWindowsNT()) {
        my $restartNeeded = 0;
        my %variablesToSet = ();

        # FIXME: We should remove this explicit version check for cygwin once we stop supporting Cygwin 1.7.9 or older versions.
        # https://bugs.webkit.org/show_bug.cgi?id=85791
        my $currentCygwinVersion = version->parse(`uname -r`);
...
}

on a recent cygwin when you enter uname -r you get something like that :


Vincent@Vincent-PC ~/tmp/Webkit-Scripts
$ uname -r
1.7.16(0.262/5/3)

As you can see the release version is not a simple version number like 1.7.8 but a more complex string,
so the version->parse function is lost and throw an exception.
I have modified the script to extract only the first part 1.7.16 and ignore the second one (0.262/5/3) and
I have replaced the call to uname -r by the function POSIX::uname.

[Vincent R.]

Created attachment 163358 [details]
patch to extract cywgin version properly

patch to extract cywgin version properly

[Alexey Proskuryakov]

Would you be willing to submit a patch to fix this issue, as described in <http://www.webkit.org/coding/contributing.html>? A patch without a ChangeLog that's not even marked for review is likely to be overlooked.

[Fujii Hironori]

AppleWin port has removed. WinCairo isn't using Cygwin.