Bug 96387 - Crash in build script when compiling on a recent cygwin version
Summary: Crash in build script when compiling on a recent cygwin version
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Major
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-11 07:32 PDT by Vincent R.
Modified: 2024-03-05 12:59 PST (History)
2 users (show)

See Also:


Attachments
patch to extract cywgin version properly (859 bytes, patch)
2012-09-11 07:33 PDT, Vincent R.
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vincent R. 2012-09-11 07:32:23 PDT
Hi,

These last days I am building lots of nightly build and I am a bit tired to apply my small patch to allow
to compile on my system(Windows XP, VS2008) so I think it would be better if I could share my patches.
THe first problem with your build system is inside webkitdirs.pm :

sub setupAppleWinEnv()
{
    return unless isAppleWinWebKit();

    if (isWindowsNT()) {
        my $restartNeeded = 0;
        my %variablesToSet = ();

        # FIXME: We should remove this explicit version check for cygwin once we stop supporting Cygwin 1.7.9 or older versions.
        # https://bugs.webkit.org/show_bug.cgi?id=85791
        my $currentCygwinVersion = version->parse(`uname -r`);
...
}

on a recent cygwin when you enter uname -r you get something like that :


Vincent@Vincent-PC ~/tmp/Webkit-Scripts
$ uname -r
1.7.16(0.262/5/3)

As you can see the release version is not a simple version number like 1.7.8 but a more complex string,
so the version->parse function is lost and throw an exception.
I have modified the script to extract only the first part 1.7.16 and ignore the second one (0.262/5/3) and
I have replaced the call to uname -r by the function POSIX::uname.
Comment 1 Vincent R. 2012-09-11 07:33:16 PDT
Created attachment 163358 [details]
patch to extract cywgin version properly

patch to extract cywgin version properly
Comment 2 Alexey Proskuryakov 2012-09-11 09:32:11 PDT
Would you be willing to submit a patch to fix this issue, as described in <http://www.webkit.org/coding/contributing.html>? A patch without a ChangeLog that's not even marked for review is likely to be overlooked.
Comment 3 Fujii Hironori 2024-03-05 12:59:15 PST
AppleWin port has removed. WinCairo isn't using Cygwin.