Bug 96379 - [WK2][WKTR] TestRunner needs to implement setApplicationCacheOriginQuota
Summary: [WK2][WKTR] TestRunner needs to implement setApplicationCacheOriginQuota
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
Depends on:
Blocks: 96374
  Show dependency treegraph
Reported: 2012-09-11 05:34 PDT by Chris Dumez
Modified: 2012-09-11 08:23 PDT (History)
3 users (show)

See Also:

Patch (7.76 KB, patch)
2012-09-11 05:46 PDT, Chris Dumez
kenneth: review+
kenneth: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (7.78 KB, patch)
2012-09-11 06:42 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-09-11 05:34:17 PDT
TestRunner needs to implement setApplicationCacheOriginQuota.

This is needed by the following test cases:
Comment 1 Chris Dumez 2012-09-11 05:46:25 PDT
Created attachment 163343 [details]
Comment 2 Chris Dumez 2012-09-11 05:46:53 PDT
Unforunately, tests cannot be unskipped yet due to Bug 96374.
Comment 3 Kenneth Rohde Christiansen 2012-09-11 05:48:30 PDT
Comment on attachment 163343 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=163343&action=review

> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:100
> +WK_EXPORT void WKBundleSetApplicationCacheOriginQuota(WKBundleRef bundle, WKStringRef origin, uint64_t quota);

so quote is in MB? I think the variable name should make that clearer
Comment 4 Chris Dumez 2012-09-11 06:42:51 PDT
Created attachment 163352 [details]
Patch for landing

Take Kenneth's feedback into consideration.
Comment 5 WebKit Review Bot 2012-09-11 08:23:14 PDT
Comment on attachment 163352 [details]
Patch for landing

Clearing flags on attachment: 163352

Committed r128190: <http://trac.webkit.org/changeset/128190>
Comment 6 WebKit Review Bot 2012-09-11 08:23:19 PDT
All reviewed patches have been landed.  Closing bug.