Bug 96373 - [chromium] consumable user gesture count off for input events
Summary: [chromium] consumable user gesture count off for input events
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-11 04:14 PDT by jochen
Modified: 2012-09-12 00:53 PDT (History)
6 users (show)

See Also:


Attachments
Patch (7.64 KB, patch)
2012-09-11 06:28 PDT, jochen
no flags Details | Formatted Diff | Diff
Patch (7.79 KB, patch)
2012-09-11 11:32 PDT, jochen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2012-09-11 04:14:56 PDT
In http://trac.webkit.org/changeset/65964 a UserGestureIndicator was introduced in chromium's webkit layer for all input events (later restricted to a subset of input events such as clicks). But even with the restriction, this still creates two consumable gestures (there's also one in WebCore/page/EventHandler for mouse events.

I guess initially this was supposed to protect against opening multiple windows from a single user gesture (chrome consumes a user gesture for each new window), however, now a web page can open two windows per event
Comment 1 jochen 2012-09-11 06:28:38 PDT
Created attachment 163348 [details]
Patch
Comment 2 WebKit Review Bot 2012-09-11 06:31:12 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 jochen 2012-09-11 06:34:06 PDT
It seems like the old code can just be removed.

I'm currently building on mac to see what wtr does with the test.
Comment 4 jochen 2012-09-11 06:57:57 PDT
Fails on both wk1 and wk2 :-/

Is it preferable to skip the layout test or move to to platform/chromium?
Comment 5 Adam Barth 2012-09-11 09:09:49 PDT
Comment on attachment 163348 [details]
Patch

I'd put it in platform/chromium because consumable user gestures are only used by chromium.
Comment 6 jochen 2012-09-11 11:32:52 PDT
Created attachment 163411 [details]
Patch
Comment 7 jochen 2012-09-11 12:21:49 PDT
Comment on attachment 163411 [details]
Patch

meh

fast/events/popup-blocking-timers.html seems to rely on creating a ton of popups with a single user event

I guess I need to rewrite the test to generate an equal amount of clicks.
Comment 8 WebKit Review Bot 2012-09-11 12:31:42 PDT
Comment on attachment 163411 [details]
Patch

Attachment 163411 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13824370

New failing tests:
fast/events/popup-blocking-timers.html
Comment 9 WebKit Review Bot 2012-09-12 00:53:37 PDT
Comment on attachment 163411 [details]
Patch

Clearing flags on attachment: 163411

Committed r128273: <http://trac.webkit.org/changeset/128273>
Comment 10 WebKit Review Bot 2012-09-12 00:53:41 PDT
All reviewed patches have been landed.  Closing bug.