Bug 96363 - Create Localizer factory method for LocaleICU
Summary: Create Localizer factory method for LocaleICU
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keishi Hattori
URL:
Keywords:
Depends on:
Blocks: 96351
  Show dependency treegraph
 
Reported: 2012-09-11 01:27 PDT by Keishi Hattori
Modified: 2012-09-11 19:24 PDT (History)
3 users (show)

See Also:


Attachments
Patch (3.69 KB, patch)
2012-09-11 01:53 PDT, Keishi Hattori
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keishi Hattori 2012-09-11 01:27:24 PDT
Create Localizer factory method for LocaleICU
Comment 1 Keishi Hattori 2012-09-11 01:53:53 PDT
Created attachment 163303 [details]
Patch
Comment 2 Kent Tamura 2012-09-11 02:03:39 PDT
Comment on attachment 163303 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163303&action=review

> Source/WebCore/platform/text/LocaleICU.cpp:47
> +    return LocaleICU::create(locale.string().utf8().data());

What happens if a broken locale name is specified?
e.g. Null AtomicString, empty string, "12345"
Comment 3 WebKit Review Bot 2012-09-11 19:24:35 PDT
Comment on attachment 163303 [details]
Patch

Clearing flags on attachment: 163303

Committed r128257: <http://trac.webkit.org/changeset/128257>
Comment 4 WebKit Review Bot 2012-09-11 19:24:38 PDT
All reviewed patches have been landed.  Closing bug.