Even user has stored the site's credentials, after restarting browser and accessing the site, the browser will still ask for credentials. By now, the blackberry porting doesn't load credentials from persistent storage.
Created attachment 163297 [details] patch This patch is not good enough in performance, but it resolved this issue. Know issues for this patch: It will search for credentials for every request before sending it including the URLs which don't require credentials. The performance issue should/would be fixed in the future patches.
This has been internally reviewed, right? (I think by me, but I forget if I gave it the final r+. I definitely looked at it.)
(In reply to comment #2) > This has been internally reviewed, right? (I think by me, but I forget if I gave it the final r+. I definitely looked at it.) Yes, you have given r+ internally to the PR200694.
Comment on attachment 163297 [details] patch LGTM.
Created attachment 164675 [details] rebase patch The code base has changed in Source/WebCore/platform/network/blackberry/NetworkManager.cpp, I re-applied the last r+ed patch and made this patch. At the same time, I added the macro BLACKBERRY_CREDENTIAL_PERSIST to include Settings.h, since it is only used by this change. +#if ENABLE(BLACKBERRY_CREDENTIAL_PERSIST) +#include "Settings.h" +#endif
Attachment 164675 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp:1020: Omit int when using unsigned [runtime/unsigned] [1] Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.h:59: Omit int when using unsigned [runtime/unsigned] [1] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 164702 [details] patch Correct the style error of the rebased patch.
Comment on attachment 164702 [details] patch Looks good.
Comment on attachment 164702 [details] patch commit.
Comment on attachment 164702 [details] patch Clearing flags on attachment: 164702 Committed r129087: <http://trac.webkit.org/changeset/129087>
All reviewed patches have been landed. Closing bug.
Created attachment 165053 [details] Fix a mistake in the last patch Since the trunk has been changed during reviewing the last patch, one line of the last patch can cause build failure. This patch is to sync with blackberry trunk.
Comment on attachment 165053 [details] Fix a mistake in the last patch Looks good.
Last patch still needs to go in.
Comment on attachment 165053 [details] Fix a mistake in the last patch Clearing flags on attachment: 165053 Committed r129392: <http://trac.webkit.org/changeset/129392>