Bug 96359 - [Qt] The ANGLE build on Windows breaks with GnuWin32's flex because it is too old
Summary: [Qt] The ANGLE build on Windows breaks with GnuWin32's flex because it is too...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Hausmann
URL:
Keywords:
Depends on: 96358
Blocks: 90879
  Show dependency treegraph
 
Reported: 2012-09-11 00:29 PDT by Simon Hausmann
Modified: 2012-09-13 01:54 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.99 KB, patch)
2012-09-11 00:39 PDT, Simon Hausmann
no flags Details | Formatted Diff | Diff
Patch (3.97 KB, patch)
2012-09-12 00:00 PDT, Simon Hausmann
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Hausmann 2012-09-11 00:29:50 PDT
[Qt] The ANGLE build on Windows breaks with GnuWin32's flex because it is too old
Comment 1 Simon Hausmann 2012-09-11 00:39:42 PDT
Created attachment 163294 [details]
Patch
Comment 2 Simon Hausmann 2012-09-11 02:04:00 PDT
The introduction of win_flex as dependency for the Windows build shall depend on https://codereview.qt-project.org/#change,34570
Comment 3 Tor Arne Vestbø 2012-09-11 02:55:31 PDT
Comment on attachment 163294 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163294&action=review

> Source/ThirdParty/ANGLE/DerivedSources.pri:17
> +# A newer version of flex is required on Windows. At the moment the only
> +# one that appears to provide binaries and is not cygwin is winflex.
> +FLEX = flex
> +win32: FLEX = win_flex

default_pre perhaps, in case we need it elsewhere?
Comment 4 Simon Hausmann 2012-09-11 02:56:32 PDT
Comment on attachment 163294 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163294&action=review

>> Source/ThirdParty/ANGLE/DerivedSources.pri:17
>> +win32: FLEX = win_flex
> 
> default_pre perhaps, in case we need it elsewhere?

Ah, you mean just set the FLEX variable in default_pre always? (or maybe only if TEMPLATE = derived)
Comment 5 Tor Arne Vestbø 2012-09-11 04:05:58 PDT
(In reply to comment #4)
> (From update of attachment 163294 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=163294&action=review
> 
> >> Source/ThirdParty/ANGLE/DerivedSources.pri:17
> >> +win32: FLEX = win_flex
> > 
> > default_pre perhaps, in case we need it elsewhere?
> 
> Ah, you mean just set the FLEX variable in default_pre always? (or maybe only if TEMPLATE = derived)

Yepp, always.
Comment 6 Simon Hausmann 2012-09-11 23:23:09 PDT
(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 163294 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=163294&action=review
> > 
> > >> Source/ThirdParty/ANGLE/DerivedSources.pri:17
> > >> +win32: FLEX = win_flex
> > > 
> > > default_pre perhaps, in case we need it elsewhere?
> > 
> > Ah, you mean just set the FLEX variable in default_pre always? (or maybe only if TEMPLATE = derived)
> 
> Yepp, always.

Alright, sounds good, I'll fix that before landing :)
Comment 7 Simon Hausmann 2012-09-12 00:00:14 PDT
Created attachment 163527 [details]
Patch

Updated patch that moves FLEX variable to default_pre.prf and fixes flex.exe vs win_flex.exe detection on Windows in build-webkit
Comment 8 WebKit Review Bot 2012-09-13 01:54:06 PDT
Comment on attachment 163527 [details]
Patch

Clearing flags on attachment: 163527

Committed r128430: <http://trac.webkit.org/changeset/128430>
Comment 9 WebKit Review Bot 2012-09-13 01:54:10 PDT
All reviewed patches have been landed.  Closing bug.