Bug 96359 – [Qt] The ANGLE build on Windows breaks with GnuWin32's flex because it is too old

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Hausmann]

[Qt] The ANGLE build on Windows breaks with GnuWin32's flex because it is too old

[Simon Hausmann]

Created attachment 163294 [details]
Patch

[Simon Hausmann]

The introduction of win_flex as dependency for the Windows build shall depend on https://codereview.qt-project.org/#change,34570

[Tor Arne Vestbø]

Comment on attachment 163294 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163294&action=review

> Source/ThirdParty/ANGLE/DerivedSources.pri:17
> +# A newer version of flex is required on Windows. At the moment the only
> +# one that appears to provide binaries and is not cygwin is winflex.
> +FLEX = flex
> +win32: FLEX = win_flex

default_pre perhaps, in case we need it elsewhere?

[Simon Hausmann]

Comment on attachment 163294 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163294&action=review

>> Source/ThirdParty/ANGLE/DerivedSources.pri:17
>> +win32: FLEX = win_flex
> 
> default_pre perhaps, in case we need it elsewhere?

Ah, you mean just set the FLEX variable in default_pre always? (or maybe only if TEMPLATE = derived)

[Tor Arne Vestbø]

(In reply to comment #4)
> (From update of attachment 163294 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=163294&action=review
> 
> >> Source/ThirdParty/ANGLE/DerivedSources.pri:17
> >> +win32: FLEX = win_flex
> > 
> > default_pre perhaps, in case we need it elsewhere?
> 
> Ah, you mean just set the FLEX variable in default_pre always? (or maybe only if TEMPLATE = derived)

Yepp, always.

[Simon Hausmann]

(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 163294 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=163294&action=review
> > 
> > >> Source/ThirdParty/ANGLE/DerivedSources.pri:17
> > >> +win32: FLEX = win_flex
> > > 
> > > default_pre perhaps, in case we need it elsewhere?
> > 
> > Ah, you mean just set the FLEX variable in default_pre always? (or maybe only if TEMPLATE = derived)
> 
> Yepp, always.

Alright, sounds good, I'll fix that before landing :)

[Simon Hausmann]

Created attachment 163527 [details]
Patch

Updated patch that moves FLEX variable to default_pre.prf and fixes flex.exe vs win_flex.exe detection on Windows in build-webkit

[WebKit Review Bot]

Comment on attachment 163527 [details]
Patch

Clearing flags on attachment: 163527

Committed r128430: <http://trac.webkit.org/changeset/128430>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.