NEW 96347
add decoration layer type 
https://bugs.webkit.org/show_bug.cgi?id=96347
Summary add decoration layer type
Daniel Sievers
Reported 2012-09-10 19:04:15 PDT
add decoration layer type
Attachments
Patch (34.50 KB, patch)
2012-09-10 19:05 PDT, Daniel Sievers 		no flags
DetailsFormatted DiffDiff
Patch (3.57 KB, patch)
2012-09-24 07:06 PDT, Daniel Sievers 		no flags
DetailsFormatted DiffDiff
Patch (3.57 KB, patch)
2012-09-24 07:13 PDT, Daniel Sievers 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Daniel Sievers
Comment 1 2012-09-10 19:05:02 PDT
Created attachment 163263 [details] Patch
WebKit Review Bot
Comment 2 2012-09-10 19:08:29 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
WebKit Review Bot
Comment 3 2012-09-10 19:08:47 PDT
Attachment 163263 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/Platform/ChangeLog', u'Source/Platf..." exit_code: 1 Source/WebCore/platform/graphics/chromium/DecorationLayerChromium.cpp:37: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/platform/graphics/chromium/DecorationLayerChromium.cpp:78: Missing space after , [whitespace/comma] [3] Source/WebCore/platform/graphics/chromium/DecorationLayerChromium.cpp:135: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WebCore/platform/graphics/chromium/cc/CCDecorationLayerImpl.cpp:143: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/platform/graphics/chromium/DecorationLayerChromium.h:57: The parameter name "bitmap" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit/chromium/src/WebDecorationLayerImpl.cpp:57: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WebKit/chromium/src/WebDecorationLayerImpl.h:44: The parameter name "bitmap" adds no information, so it should be removed. [readability/parameter_name] [5] Source/Platform/chromium/public/WebDecorationLayer.h:45: The parameter name "bitmap" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 8 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Daniel Sievers
Comment 4 2012-09-10 19:09:21 PDT
I started hacking on this, it's still work in progress and most importantly needs unit tests. But the idea is to make this a sibling of the window. Then you can use the layer bounds to change its size while the corner quads do not scale. On the other hand, by applying a transform on it you can make the whole thing scale uniformly.
Adrienne Walker
Comment 5 2012-09-11 09:35:22 PDT
Comment on attachment 163263 [details] Patch Since some layers are going to need multiple decorations and I think it's important to be able to share decorations across multiple layers, I was hoping that we could pull the decoration texture management out of a derived layer type into something more central. I put a DecorationManager proposal up in Google Docs a while back and shared it with you. Did you have any thoughts on that approach vs this approach of having layers do all the resource management explicitly?
Daniel Sievers
Comment 6 2012-09-24 07:06:32 PDT
Created attachment 165372 [details] Patch
Daniel Sievers
Comment 7 2012-09-24 07:13:12 PDT
Created attachment 165375 [details] Patch
Daniel Sievers
Comment 8 2012-09-24 07:13:47 PDT
Moving to https://codereview.chromium.org/10963056
Note You need to log in before you can comment on or make changes to this bug.