Bug 96346 - [CMake] Remove duplicated file in CMakeLists.txt
Summary: [CMake] Remove duplicated file in CMakeLists.txt
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on: 91575
Blocks:
  Show dependency treegraph
 
Reported: 2012-09-10 18:15 PDT by Gyuyoung Kim
Modified: 2012-09-10 20:49 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.58 KB, patch)
2012-09-10 18:19 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2012-09-10 18:15:54 PDT
Below files are already added to main file list in WebCore/CMakeLists.txt. So, this should be removed.


IF (ENABLE_REQUEST_ANIMATION_FRAME)
    LIST(APPEND WebCore_IDL_FILES
        dom/RequestAnimationFrameCallback.idl
    )
    LIST(APPEND WebCore_SOURCES
        dom/ScriptedAnimationController.cpp
    )
ENDIF ()

IF (ENABLE_VIBRATION)
    LIST(APPEND WebCore_INCLUDE_DIRECTORIES
        ${WEBCORE_DIR}/Modules/vibration
    )
    LIST(APPEND WebCore_IDL_FILES
        Modules/vibration/NavigatorVibration.idl
    )
    LIST(APPEND WebCore_SOURCES
        Modules/vibration/NavigatorVibration.cpp
        Modules/vibration/Vibration.cpp
    )
ENDIF ()
Comment 1 Gyuyoung Kim 2012-09-10 18:19:24 PDT
Created attachment 163259 [details]
Patch
Comment 2 Benjamin Poulain 2012-09-10 19:25:34 PDT
Comment on attachment 163259 [details]
Patch

Shouldn't it be the other way around? Remove the files from the main section, and keep the guarded build one?
What if you want a build without ENABLE_VIBRATION?
Comment 3 Benjamin Poulain 2012-09-10 20:37:53 PDT
Comment on attachment 163259 [details]
Patch

Ok, the file are #ifdef'ed and you prefer to support only that way.
Comment 4 WebKit Review Bot 2012-09-10 20:49:54 PDT
Comment on attachment 163259 [details]
Patch

Clearing flags on attachment: 163259

Committed r128143: <http://trac.webkit.org/changeset/128143>
Comment 5 WebKit Review Bot 2012-09-10 20:49:58 PDT
All reviewed patches have been landed.  Closing bug.