Bug 96346 – [CMake] Remove duplicated file in CMakeLists.txt

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Gyuyoung Kim]

Below files are already added to main file list in WebCore/CMakeLists.txt. So, this should be removed.


IF (ENABLE_REQUEST_ANIMATION_FRAME)
    LIST(APPEND WebCore_IDL_FILES
        dom/RequestAnimationFrameCallback.idl
    )
    LIST(APPEND WebCore_SOURCES
        dom/ScriptedAnimationController.cpp
    )
ENDIF ()

IF (ENABLE_VIBRATION)
    LIST(APPEND WebCore_INCLUDE_DIRECTORIES
        ${WEBCORE_DIR}/Modules/vibration
    )
    LIST(APPEND WebCore_IDL_FILES
        Modules/vibration/NavigatorVibration.idl
    )
    LIST(APPEND WebCore_SOURCES
        Modules/vibration/NavigatorVibration.cpp
        Modules/vibration/Vibration.cpp
    )
ENDIF ()

[Gyuyoung Kim]

Created attachment 163259 [details]
Patch

[Benjamin Poulain]

Comment on attachment 163259 [details]
Patch

Shouldn't it be the other way around? Remove the files from the main section, and keep the guarded build one?
What if you want a build without ENABLE_VIBRATION?

[Benjamin Poulain]

Comment on attachment 163259 [details]
Patch

Ok, the file are #ifdef'ed and you prefer to support only that way.

[WebKit Review Bot]

Comment on attachment 163259 [details]
Patch

Clearing flags on attachment: 163259

Committed r128143: <http://trac.webkit.org/changeset/128143>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.