WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
96319
Rename box-sizing applying methods to be more clear about just applying box-sizing.
https://bugs.webkit.org/show_bug.cgi?id=96319
Summary
Rename box-sizing applying methods to be more clear about just applying box-s...
Ojan Vafai
Reported
2012-09-10 14:31:40 PDT
Rename box-sizing applying methods to be more clear about just applying box-sizing.
Attachments
Patch
(41.67 KB, patch)
2012-09-10 14:33 PDT
,
Ojan Vafai
no flags
Details
Formatted Diff
Diff
Patch for landing
(41.91 KB, patch)
2012-09-10 14:50 PDT
,
Ojan Vafai
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Ojan Vafai
Comment 1
2012-09-10 14:33:23 PDT
Created
attachment 163210
[details]
Patch
Tony Chang
Comment 2
2012-09-10 14:39:31 PDT
Comment on
attachment 163210
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=163210&action=review
> Source/WebCore/rendering/AutoTableLayout.cpp:96 > + LayoutUnit logicalWidth = cell->adjustBorderLogicalWidthForBoxSizing(cellLogicalWidth.value());
Nit: I would call it adjustBorderBoxLogicalWidthForBoxSizing to make it clear that we're not talking about the border width.
> Source/WebCore/rendering/RenderBlock.cpp:5555 > + m_minPreferredLogicalWidth = m_maxPreferredLogicalWidth = adjustContentLogicalWidthForBoxSizing(styleToUse->logicalWidth().value());
Nit: adjustContentBoxLogicalWidthForBoxSizing.
Ojan Vafai
Comment 3
2012-09-10 14:50:49 PDT
Created
attachment 163214
[details]
Patch for landing
WebKit Review Bot
Comment 4
2012-09-10 16:55:15 PDT
Comment on
attachment 163214
[details]
Patch for landing Clearing flags on attachment: 163214 Committed
r128130
: <
http://trac.webkit.org/changeset/128130
>
WebKit Review Bot
Comment 5
2012-09-10 16:55:18 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug