Bug 96319 - Rename box-sizing applying methods to be more clear about just applying box-sizing.
Summary: Rename box-sizing applying methods to be more clear about just applying box-s...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-10 14:31 PDT by Ojan Vafai
Modified: 2012-09-10 16:55 PDT (History)
4 users (show)

See Also:

Attachments
Patch (41.67 KB, patch)
2012-09-10 14:33 PDT, Ojan Vafai 		no flags Details | Formatted Diff | Diff
Patch for landing (41.91 KB, patch)
2012-09-10 14:50 PDT, Ojan Vafai 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2012-09-10 14:31:40 PDT 
Rename box-sizing applying methods to be more clear about just applying box-sizing.
Comment 1 Ojan Vafai 2012-09-10 14:33:23 PDT 
Created attachment 163210 [details]
Patch
Comment 2 Tony Chang 2012-09-10 14:39:31 PDT 
Comment on attachment 163210 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163210&action=review

> Source/WebCore/rendering/AutoTableLayout.cpp:96
> +                            LayoutUnit logicalWidth = cell->adjustBorderLogicalWidthForBoxSizing(cellLogicalWidth.value());

Nit: I would call it adjustBorderBoxLogicalWidthForBoxSizing to make it clear that we're not talking about the border width.

> Source/WebCore/rendering/RenderBlock.cpp:5555
> +        m_minPreferredLogicalWidth = m_maxPreferredLogicalWidth = adjustContentLogicalWidthForBoxSizing(styleToUse->logicalWidth().value());

Nit: adjustContentBoxLogicalWidthForBoxSizing.
Comment 3 Ojan Vafai 2012-09-10 14:50:49 PDT 
Created attachment 163214 [details]
Patch for landing
Comment 4 WebKit Review Bot 2012-09-10 16:55:15 PDT 
Comment on attachment 163214 [details]
Patch for landing

Clearing flags on attachment: 163214

Committed r128130: <http://trac.webkit.org/changeset/128130>
Comment 5 WebKit Review Bot 2012-09-10 16:55:18 PDT 
All reviewed patches have been landed.  Closing bug.