Bug 96312 - [V8] currentDocument doesn't need to handle the case where there is no v8::Context
Summary: [V8] currentDocument doesn't need to handle the case where there is no v8::Co...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-10 13:41 PDT by Adam Barth
Modified: 2012-09-10 16:21 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.55 KB, patch)
2012-09-10 13:42 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-09-10 13:41:33 PDT 
[V8] currentDocument doesn't need to handle the case where there is no v8::Context
Comment 1 Adam Barth 2012-09-10 13:42:17 PDT 
Created attachment 163197 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-09-10 13:46:55 PDT 
Comment on attachment 163197 [details]
Patch

k
Comment 3 Kentaro Hara 2012-09-10 13:48:25 PDT 
In a series of your patches, it might be better to insert ASSERT() where the condition is not so obvious for ordinary people:)
Comment 4 Adam Barth 2012-09-10 13:53:41 PDT 
> In a series of your patches, it might be better to insert ASSERT() where the condition is not so obvious for ordinary people:)

Sure.  If you see places where you think that would be useful, please mention them and I will add the ASSERTs.
Comment 5 Adam Barth 2012-09-10 16:21:19 PDT 
Comment on attachment 163197 [details]
Patch

Clearing flags on attachment: 163197

Committed r128124: <http://trac.webkit.org/changeset/128124>
Comment 6 Adam Barth 2012-09-10 16:21:21 PDT 
All reviewed patches have been landed.  Closing bug.