Now that no one is using the ClassInfo in JSCell, we can remove it for the greater good.
Created attachment 163257 [details] Patch
Created attachment 163258 [details] Patch
Comment on attachment 163258 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163258&action=review r=me assuming 32_64 changes are in fact legitimate > Source/JavaScriptCore/llint/LowLevelInterpreter.asm:91 > + const InlineStorageCapacity = 7 Does 32bit gain a full JSValue in a cell? You've removed one pointer but a value is 64bits. > Source/JavaScriptCore/runtime/PropertyOffset.h:39 > -#define INLINE_STORAGE_CAPACITY 6 > +#define INLINE_STORAGE_CAPACITY 7 > #else > -#define INLINE_STORAGE_CAPACITY 5 > +#define INLINE_STORAGE_CAPACITY 6 See my earlier comment
(In reply to comment #3) > (From update of attachment 163258 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=163258&action=review > > r=me assuming 32_64 changes are in fact legitimate > > > Source/JavaScriptCore/llint/LowLevelInterpreter.asm:91 > > + const InlineStorageCapacity = 7 > > Does 32bit gain a full JSValue in a cell? You've removed one pointer but a value is 64bits. > It should be okay because I removed a void* that was added on 32_64 to pad out JSObjects after I removed inheritorID a while back. So technically there were two pointer-sized removals on 32_64 in this patch.
> It should be okay because I removed a void* that was added on 32_64 to pad out JSObjects after I removed inheritorID a while back. So technically there were two pointer-sized removals on 32_64 in this patch. (See changes to JSObject.h in this patch)
Comment on attachment 163258 [details] Patch Clearing flags on attachment: 163258 Committed r128146: <http://trac.webkit.org/changeset/128146>
All reviewed patches have been landed. Closing bug.